From: David Miller <davem@davemloft.net>
To: gallatin@myri.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] myri10ge: fix most sparse warnings
Date: Wed, 05 Dec 2012 16:25:46 -0500 (EST) [thread overview]
Message-ID: <20121205.162546.1187131916097405931.davem@davemloft.net> (raw)
In-Reply-To: <1354652235-13174-1-git-send-email-gallatin@myri.com>
From: Andrew Gallatin <gallatin@myri.com>
Date: Tue, 4 Dec 2012 15:17:15 -0500
> - convert remaining htonl/ntohl +__raw_read/__raw_writel to
> swab32 + readl/writel
> - add missing __iomem qualifier in myri10ge_open()
> - fix dubious: x & !y warning by switching from logical to bitwise not
>
> The swab32 conversion fixes a bug in myri10ge_led() where
> big-endian machines would write the wrong pattern.
>
> The only remaining warning (lock context imbalance) is due to
> the use of __netif_tx_trylock(), and cannot easily be fixed.
>
> Signed-off-by: Andrew Gallatin <gallatin@myri.com>
Applied.
prev parent reply other threads:[~2012-12-05 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 20:17 [PATCH net-next] myri10ge: fix most sparse warnings Andrew Gallatin
2012-12-05 21:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205.162546.1187131916097405931.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gallatin@myri.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).