From: David Miller <davem@davemloft.net>
To: dinggnu@gmail.com
Cc: ebiederm@xmission.com, edumazet@google.com, xemul@parallels.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: core: fix unused variable sparse warning
Date: Thu, 06 Dec 2012 22:25:56 -0500 (EST) [thread overview]
Message-ID: <20121206.222556.600775306911649606.davem@davemloft.net> (raw)
In-Reply-To: <20121207001545.GE2510@gmail.com>
From: Cong Ding <dinggnu@gmail.com>
Date: Fri, 7 Dec 2012 00:15:47 +0000
> On Fri, Dec 07, 2012 at 12:06:44AM +0000, Cong Ding wrote:
>> the variables zero and unres_qlen_max are only used when CONFIG_SYSCTL is
>> defined, otherwise it causes the following sparse warning when we turn on
>> CONFIG_SYSCTL.
> sorry for disturbing again, the sparse warning is
> net/core/neighbour.c:65:12: warning: ‘zero’ defined but not used [-Wunused-variable]
> net/core/neighbour.c:66:12: warning: ‘unres_qlen_max’ defined but not used [-Wunused-variable]
>
> it happens if we turn off CONFIG_SYSCTL.
A patch for this has already in my tree for nearly a whole day.
next prev parent reply other threads:[~2012-12-07 3:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 0:06 [PATCH] net: core: fix unused variable sparse warning Cong Ding
2012-12-07 0:15 ` Cong Ding
2012-12-07 3:25 ` David Miller [this message]
2012-12-07 10:45 ` Shan Wei
2012-12-07 2:26 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206.222556.600775306911649606.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dinggnu@gmail.com \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).