From: Thomas Graf <tgraf@suug.ch>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH] sctp: Add RCU protection to assoc->transport_addr_list
Date: Thu, 6 Dec 2012 19:28:52 +0000 [thread overview]
Message-ID: <20121206192852.GG16122@casper.infradead.org> (raw)
In-Reply-To: <50C0EE8E.3080505@gmail.com>
On 12/06/12 at 02:14pm, Vlad Yasevich wrote:
> Right, but there may be chunks that have cached association with a ref
> before sctp_association_free() is called. Now, after free they may
> be looking at the transport list for whatever reason... Most places
> check assoc->dead, but I don't want to get caught. So, there is
> a remote chance that someone may look at transports and would crash
> without rcu.
You are right, sctp_associate_free() can be called even though there
may still be multiple refs on that assoc around. We are currently
fine as I believe sk_lock serializes all the accesses but better
be safe than sorry.
I've respun the patches in a v2 patch series.
prev parent reply other threads:[~2012-12-06 19:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 18:15 [PATCH] sctp: Add RCU protection to assoc->transport_addr_list Thomas Graf
2012-12-06 18:35 ` Vlad Yasevich
2012-12-06 18:44 ` Thomas Graf
2012-12-06 18:57 ` Vlad Yasevich
2012-12-06 19:08 ` Thomas Graf
2012-12-06 19:14 ` Vlad Yasevich
2012-12-06 19:28 ` Thomas Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206192852.GG16122@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).