From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: gro: fix possible panic in skb_gro_receive()
Date: Fri, 07 Dec 2012 14:41:19 -0500 (EST) [thread overview]
Message-ID: <20121207.144119.1859602274016402253.davem@davemloft.net> (raw)
In-Reply-To: <1354838099.10983.10.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 06 Dec 2012 15:54:59 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> commit 2e71a6f8084e (net: gro: selective flush of packets) added
> a bug for skbs using frag_list. This part of the GRO stack is rarely
> used, as it needs skb not using a page fragment for their skb->head.
>
> Most drivers do use a page fragment, but some of them use GFP_KERNEL
> allocations for the initial fill of their RX ring buffer.
>
> napi_gro_flush() overwrite skb->prev that was used for these skb to
> point to the last skb in frag_list.
>
> Fix this using a separate field in struct napi_gro_cb to point to the
> last fragment.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2012-12-07 19:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 23:54 [PATCH] net: gro: fix possible panic in skb_gro_receive() Eric Dumazet
2012-12-07 19:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121207.144119.1859602274016402253.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).