* [PATCH] fix initializer entry defined twice issue
@ 2012-12-06 23:16 Cong Ding
2012-12-06 23:59 ` Patrick Trantham
0 siblings, 1 reply; 4+ messages in thread
From: Cong Ding @ 2012-12-06 23:16 UTC (permalink / raw)
To: David S. Miller, Otavio Salvador, Javier Martinez Canillas,
Patrick Trantham, Jiri Kosina, netdev, linux-kernel
Cc: Cong Ding
the ".config_intr" is defined twice in both line 208 and 212.
Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
drivers/net/phy/smsc.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
index 16dceed..5cee6bd 100644
--- a/drivers/net/phy/smsc.c
+++ b/drivers/net/phy/smsc.c
@@ -205,7 +205,6 @@ static struct phy_driver smsc_phy_driver[] = {
/* basic functions */
.config_aneg = genphy_config_aneg,
.read_status = lan87xx_read_status,
- .config_intr = smsc_phy_config_intr,
/* IRQ related */
.ack_interrupt = smsc_phy_ack_interrupt,
--
1.7.4.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fix initializer entry defined twice issue
2012-12-06 23:16 [PATCH] fix initializer entry defined twice issue Cong Ding
@ 2012-12-06 23:59 ` Patrick Trantham
2012-12-07 0:05 ` Cong Ding
0 siblings, 1 reply; 4+ messages in thread
From: Patrick Trantham @ 2012-12-06 23:59 UTC (permalink / raw)
To: Cong Ding
Cc: David S. Miller, Otavio Salvador, Javier Martinez Canillas,
Jiri Kosina, netdev, linux-kernel
On 12/06/2012 05:16 PM, Cong Ding wrote:
> the ".config_intr" is defined twice in both line 208 and 212.
>
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
> ---
> drivers/net/phy/smsc.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
> index 16dceed..5cee6bd 100644
> --- a/drivers/net/phy/smsc.c
> +++ b/drivers/net/phy/smsc.c
> @@ -205,7 +205,6 @@ static struct phy_driver smsc_phy_driver[] = {
> /* basic functions */
> .config_aneg = genphy_config_aneg,
> .read_status = lan87xx_read_status,
> - .config_intr = smsc_phy_config_intr,
>
> /* IRQ related */
> .ack_interrupt = smsc_phy_ack_interrupt,
Hi Cong,
That looks like a mistake from my previous patch to that file. Copy and
paste fail.
The line should read:
.config_init = smsc_phy_config_init,
I can submit a patch once I get off work unless you beat me to it.
regards,
Patrick
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fix initializer entry defined twice issue
2012-12-06 23:59 ` Patrick Trantham
@ 2012-12-07 0:05 ` Cong Ding
2012-12-07 19:51 ` Patrick Trantham
0 siblings, 1 reply; 4+ messages in thread
From: Cong Ding @ 2012-12-07 0:05 UTC (permalink / raw)
To: Patrick Trantham
Cc: David S. Miller, Otavio Salvador, Javier Martinez Canillas,
Jiri Kosina, netdev, linux-kernel
On Thu, Dec 06, 2012 at 05:59:21PM -0600, Patrick Trantham wrote:
> On 12/06/2012 05:16 PM, Cong Ding wrote:
> >the ".config_intr" is defined twice in both line 208 and 212.
> >
> >Signed-off-by: Cong Ding <dinggnu@gmail.com>
> >---
> > drivers/net/phy/smsc.c | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
> >index 16dceed..5cee6bd 100644
> >--- a/drivers/net/phy/smsc.c
> >+++ b/drivers/net/phy/smsc.c
> >@@ -205,7 +205,6 @@ static struct phy_driver smsc_phy_driver[] = {
> > /* basic functions */
> > .config_aneg = genphy_config_aneg,
> > .read_status = lan87xx_read_status,
> >- .config_intr = smsc_phy_config_intr,
> > /* IRQ related */
> > .ack_interrupt = smsc_phy_ack_interrupt,
>
> Hi Cong,
>
> That looks like a mistake from my previous patch to that file. Copy
> and paste fail.
>
> The line should read:
> .config_init = smsc_phy_config_init,
>
> I can submit a patch once I get off work unless you beat me to it.
Thanks for the note. It's better that you submit a patch together with your
code.
- cong
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fix initializer entry defined twice issue
2012-12-07 0:05 ` Cong Ding
@ 2012-12-07 19:51 ` Patrick Trantham
0 siblings, 0 replies; 4+ messages in thread
From: Patrick Trantham @ 2012-12-07 19:51 UTC (permalink / raw)
To: Cong Ding
Cc: David S. Miller, Otavio Salvador, Javier Martinez Canillas,
Jiri Kosina, netdev, linux-kernel
On 12/06/2012 06:05 PM, Cong Ding wrote:
> On Thu, Dec 06, 2012 at 05:59:21PM -0600, Patrick Trantham wrote:
>> On 12/06/2012 05:16 PM, Cong Ding wrote:
>>> the ".config_intr" is defined twice in both line 208 and 212.
>>>
>>> Signed-off-by: Cong Ding <dinggnu@gmail.com>
>>> ---
>>> drivers/net/phy/smsc.c | 1 -
>>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
>>> index 16dceed..5cee6bd 100644
>>> --- a/drivers/net/phy/smsc.c
>>> +++ b/drivers/net/phy/smsc.c
>>> @@ -205,7 +205,6 @@ static struct phy_driver smsc_phy_driver[] = {
>>> /* basic functions */
>>> .config_aneg = genphy_config_aneg,
>>> .read_status = lan87xx_read_status,
>>> - .config_intr = smsc_phy_config_intr,
>>> /* IRQ related */
>>> .ack_interrupt = smsc_phy_ack_interrupt,
>> Hi Cong,
>>
>> That looks like a mistake from my previous patch to that file. Copy
>> and paste fail.
>>
>> The line should read:
>> .config_init = smsc_phy_config_init,
>>
>> I can submit a patch once I get off work unless you beat me to it.
> Thanks for the note. It's better that you submit a patch together with your
> code.
>
> - cong
Patch submitted, thanks for pointing this out!
- Patrick
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-12-07 19:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-06 23:16 [PATCH] fix initializer entry defined twice issue Cong Ding
2012-12-06 23:59 ` Patrick Trantham
2012-12-07 0:05 ` Cong Ding
2012-12-07 19:51 ` Patrick Trantham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).