From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net Date: Fri, 7 Dec 2012 15:13:30 -0800 Message-ID: <20121207151330.3cd111a4@samsung-9> References: <1354899897-10423-1-git-send-email-jasowang@redhat.com> <20121207.153556.989159003987459765.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: krkumar2@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, bhutchings@solarflare.com, jwhan@filewood.snu.ac.kr, shiyer@redhat.com To: David Miller Return-path: In-Reply-To: <20121207.153556.989159003987459765.davem@davemloft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Fri, 07 Dec 2012 15:35:56 -0500 (EST) David Miller wrote: > From: Jason Wang > Date: Sat, 8 Dec 2012 01:04:54 +0800 > > > This series is an update version (hope the final version) of multiqueue > > (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were > > addressed, the work were based on Krishna Kumar's work to let virtio-net use > > multiple rx/tx queues to do the packets reception and transmission. Performance > > test show the aggregate latency were increased greately but may get some > > regression in small packet transmission. Due to this, multiqueue were disabled > > by default. If user want to benefit form the multiqueue, ethtool -L could be > > used to enable the feature. > > > > Please review and comments. > > > > A protype implementation of qemu-kvm support could by found in > > git://github.com/jasowang/qemu-kvm-mq.git. To start a guest with two queues, you > > could specify the queues parameters to both tap and virtio-net like: > > > > ./qemu-kvm -netdev tap,queues=2,... -device virtio-net-pci,queues=2,... > > > > then enable the multiqueue through ethtool by: > > > > ethtool -L eth0 combined 2 > > It seems like most, if not all, of the feedback given for this series > has been addressed by Jason. > > Can I get some ACKs? Other than the minor style nit in the first patch, I see no issues. This is really needed by Virtual Routers. Acked-by: Stephen Hemminger