From: David Miller <davem@davemloft.net>
To: ariele@broadcom.com
Cc: netdev@vger.kernel.org, eilong@broadcom.com
Subject: Re: [PATCH net-next v3 01/22] bnx2x: Support probing and removing of VF device
Date: Mon, 10 Dec 2012 13:35:19 -0500 (EST) [thread overview]
Message-ID: <20121210.133519.2048543022289027034.davem@davemloft.net> (raw)
In-Reply-To: <1355154406-10855-2-git-send-email-ariele@broadcom.com>
From: "Ariel Elior" <ariele@broadcom.com>
Date: Mon, 10 Dec 2012 17:46:25 +0200
> static void bnx2x_get_pcie_width_speed(struct bnx2x *bp, int *width, int *speed)
> {
> - u32 val = REG_RD(bp, PCICFG_OFFSET + PCICFG_LINK_CONTROL);
> + u32 val = 0;
> + pci_read_config_dword(bp->pdev, PCICFG_LINK_CONTROL, &val);
Please put an empty line between function local variable declarations
and actual code.
> @@ -12023,85 +12057,115 @@ static int bnx2x_get_num_non_def_sbs(struct pci_dev *pdev,
> * If MSI-X is not supported - return number of SBs needed to support
> * one fast path queue: one FP queue + SB for CNIC
> */
> - if (!pos)
> + if (!pos) {
> + pr_info("no msix capability found");
> return 1 + cnic_cnt;
> + }
> +
> + pr_info("msix capability found");
>
Use dev_info(), netdev_info(), or similar, rather than plain
pr_info().
next prev parent reply other threads:[~2012-12-10 18:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 15:46 [PATCH v3 net-next 00/22] bnx2x: support SR-IOV Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 01/22] bnx2x: Support probing and removing of VF device Ariel Elior
2012-12-10 18:35 ` David Miller [this message]
2012-12-10 18:50 ` Joe Perches
2012-12-10 15:46 ` [PATCH net-next v3 02/22] bnx2x: VF <-> PF channel 'acquire' at vf probe Ariel Elior
2012-12-10 18:37 ` David Miller
2012-12-10 15:46 ` [PATCH net-next v3 03/22] bnx2x: Add to VF <-> PF channel the release request Ariel Elior
2012-12-10 18:39 ` David Miller
2012-12-10 15:46 ` [PATCH net-next v3 04/22] bnx2x: Separate VF and PF logic Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 05/22] bnx2x: Add init, setup_q, set_mac to VF <-> PF channel Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 06/22] bnx2x: Add teardown_q and close " Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 07/22] bnx2x: Support ndo_set_rxmode in VF driver Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 08/22] bnx2x: VF fastpath Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 09/22] bnx2x: Allocate VF database in PF when VFs are present Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 10/22] bnx2x: Prepare device and initialize VF database Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 11/22] bnx2x: Infrastructure for VF <-> PF request on PF side Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 12/22] bnx2x: Support of PF driver of a VF acquire request Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 13/22] bnx2x: Support of PF driver of a VF init request Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 14/22] bnx2x: Support statistics collection for VFs by the PF Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 15/22] bnx2x: Support of PF driver of a VF setup_q request Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 16/22] bnx2x: Support of PF driver of a VF q_filters request Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 17/22] bnx2x: Support of PF driver of a VF q_teardown request Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 18/22] bnx2x: Support of PF driver of a VF close request Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 19/22] bnx2x: Support of PF driver of a VF release request Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 20/22] bnx2x: Support VF FLR Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 21/22] bnx2x: Support PF <-> VF Bulletin Board Ariel Elior
2012-12-10 15:46 ` [PATCH net-next v3 22/22] bnx2x: Add VF device ids and enable feature Ariel Elior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210.133519.2048543022289027034.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariele@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).