* [Patch net-next] virtio_net: fix a typo in virtnet_alloc_queues()
@ 2012-12-10 12:24 Cong Wang
2012-12-10 18:46 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Cong Wang @ 2012-12-10 12:24 UTC (permalink / raw)
To: netdev; +Cc: Jason Wang, David S. Miller, Cong Wang
Obviously it should check !vi->rq.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index a644eeb..68d64f0 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1347,7 +1347,7 @@ static int virtnet_alloc_queues(struct virtnet_info *vi)
if (!vi->sq)
goto err_sq;
vi->rq = kzalloc(sizeof(*vi->rq) * vi->max_queue_pairs, GFP_KERNEL);
- if (!vi->sq)
+ if (!vi->rq)
goto err_rq;
INIT_DELAYED_WORK(&vi->refill, refill_work);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch net-next] virtio_net: fix a typo in virtnet_alloc_queues()
2012-12-10 12:24 [Patch net-next] virtio_net: fix a typo in virtnet_alloc_queues() Cong Wang
@ 2012-12-10 18:46 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-12-10 18:46 UTC (permalink / raw)
To: amwang; +Cc: netdev, jasowang
From: Cong Wang <amwang@redhat.com>
Date: Mon, 10 Dec 2012 20:24:08 +0800
> Obviously it should check !vi->rq.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-10 18:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-10 12:24 [Patch net-next] virtio_net: fix a typo in virtnet_alloc_queues() Cong Wang
2012-12-10 18:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).