From: David Miller <davem@davemloft.net>
To: rmody@brocade.com
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com,
David.Laight@ACULAB.COM, adapter_linux_open_src_team@brocade.com
Subject: Re: [net-next 1/7] bna: Code Cleanup and Enhancements
Date: Mon, 10 Dec 2012 17:13:49 -0500 (EST) [thread overview]
Message-ID: <20121210.171349.1368932708858713762.davem@davemloft.net> (raw)
In-Reply-To: <1355175725-19202-2-git-send-email-rmody@brocade.com>
From: Rasesh Mody <rmody@brocade.com>
Date: Mon, 10 Dec 2012 13:41:59 -0800
> - skb = unmap_array[unmap_cons].skb;
> - BUG_ON(!(skb));
> - unmap_array[unmap_cons].skb = NULL;
> + curr_ua = &unmap_array[unmap_cons];
> +
> + skb = curr_ua->skb;
> + BUG_ON(!(skb));\
^^^
Really?
Please carefully review your own work before submitting it for
inclusion. When you have erroneous things like this in the
very first patch it reflects very poorly upon the quality of
your work.
next prev parent reply other threads:[~2012-12-10 22:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 21:41 [net-next 0/7] bna: Driver Version Updated to 3.1.2.1 Rasesh Mody
2012-12-10 21:41 ` [net-next 1/7] bna: Code Cleanup and Enhancements Rasesh Mody
2012-12-10 22:13 ` David Miller [this message]
2012-12-11 0:39 ` Rasesh Mody
2012-12-10 21:42 ` [net-next 2/7] bna: Tx and Rx Optimizations Rasesh Mody
2012-12-10 21:42 ` [net-next 3/7] bna: TX Intr Coalescing Fix Rasesh Mody
2012-12-10 21:42 ` [net-next 4/7] bna: Rx Page Based Allocation Rasesh Mody
2012-12-10 21:42 ` [net-next 5/7] bna: Add RX State Rasesh Mody
2012-12-10 21:42 ` [net-next 6/7] bna: Firmware update Rasesh Mody
2012-12-10 21:42 ` [net-next 7/7] bna: Driver Version Updated to 3.1.2.1 Rasesh Mody
-- strict thread matches above, loose matches on Subject: below --
2012-12-11 22:24 [net-next 0/7] " Rasesh Mody
2012-12-11 22:24 ` [net-next 1/7] bna: Code Cleanup and Enhancements Rasesh Mody
2012-12-06 23:17 [net-next 0/7] bna: Driver Version Updated to 3.1.2.1 Rasesh Mody
2012-12-06 23:17 ` [net-next 1/7] bna: Code Cleanup and Enhancements Rasesh Mody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210.171349.1368932708858713762.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@ACULAB.COM \
--cc=adapter_linux_open_src_team@brocade.com \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).