* [PATCH] iproute2: ss - change default filter to include all socket types
@ 2012-12-11 16:42 Petr Šabata
2012-12-11 17:45 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Petr Šabata @ 2012-12-11 16:42 UTC (permalink / raw)
To: shemminger; +Cc: netdev, Petr Šabata
Currently the default filter lists TCP sockets only which is
rather confusing especially when the '-a/--all' flag is used.
This patch changes the default to include all sockets, imitating
netstat(8) behavior.
Signed-off-by: Petr Šabata <contyk@redhat.com>
---
misc/ss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index b45f5ba..b8cd60d 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -105,7 +105,7 @@ struct filter
};
struct filter default_filter = {
- .dbs = (1<<TCP_DB),
+ .dbs = ~0,
.states = SS_ALL & ~((1<<SS_LISTEN)|(1<<SS_CLOSE)|(1<<SS_TIME_WAIT)|(1<<SS_SYN_RECV)),
.families= (1<<AF_INET)|(1<<AF_INET6),
};
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iproute2: ss - change default filter to include all socket types
2012-12-11 16:42 [PATCH] iproute2: ss - change default filter to include all socket types Petr Šabata
@ 2012-12-11 17:45 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-12-11 17:45 UTC (permalink / raw)
To: contyk; +Cc: shemminger, netdev
From: Petr Šabata <contyk@redhat.com>
Date: Tue, 11 Dec 2012 17:42:52 +0100
> Currently the default filter lists TCP sockets only which is
> rather confusing especially when the '-a/--all' flag is used.
> This patch changes the default to include all sockets, imitating
> netstat(8) behavior.
>
> Signed-off-by: Petr Šabata <contyk@redhat.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-11 17:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-11 16:42 [PATCH] iproute2: ss - change default filter to include all socket types Petr Šabata
2012-12-11 17:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).