From: David Miller <davem@davemloft.net>
To: mugunthanvnm@ti.com
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org, s.hauer@pengutronix.de
Subject: Re: [PATCH v2 1/1] net: ethernet: davinci_cpdma: Add boundary for rx and tx descriptors
Date: Tue, 11 Dec 2012 13:30:58 -0500 (EST) [thread overview]
Message-ID: <20121211.133058.2238010228178961245.davem@davemloft.net> (raw)
In-Reply-To: <1355197433-7492-1-git-send-email-mugunthanvnm@ti.com>
You cannot do this.
After your changes the driver no longer does any TX flow control.
It never stops the TX queue and never wakes it up later.
It just drops packets on the floor when it runs out of descriptors.
This breaks everything, and in particular packet schedulers and
TCP.
I'm not applying this.
next prev parent reply other threads:[~2012-12-11 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 3:43 [PATCH v2 1/1] net: ethernet: davinci_cpdma: Add boundary for rx and tx descriptors Mugunthan V N
2012-12-11 18:30 ` David Miller [this message]
2012-12-11 18:34 ` David Miller
2012-12-11 18:54 ` Eric Dumazet
2012-12-11 18:57 ` David Miller
2012-12-11 19:07 ` Eric Dumazet
2012-12-12 13:38 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121211.133058.2238010228178961245.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).