From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: wangchen@cn.fujitsu.com, netdev@vger.kernel.org
Subject: Re: netdevice wanrouter: Convert directly reference of netdev->priv
Date: Tue, 11 Dec 2012 13:43:10 -0500 (EST) [thread overview]
Message-ID: <20121211.134310.1757064654502486858.davem@davemloft.net> (raw)
In-Reply-To: <20121203090405.GA12089@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 3 Dec 2012 12:04:05 +0300
> I suspect we should just revert the patch?
That is absolutely something we cannot do.
netdev->priv no longer exists, first of all.
And the whole point of this change was to allow us to
remove any and all references to netdev->priv, exactly
so that we could remove it altogether.
If you look at the commit in question, the idea is to
allocate the netdev in the ->new_if() callback.
And that's in fact what happens.
What's missing at the top level is something like:
dev = wandev->dev;
And perhaps removing the 'dev' argument to the ->new_if()
method since it obviously is always NULL and never actually
used.
Thanks.
next prev parent reply other threads:[~2012-12-11 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 9:04 netdevice wanrouter: Convert directly reference of netdev->priv Dan Carpenter
2012-12-11 18:43 ` David Miller [this message]
2012-12-11 18:46 ` David Miller
2012-12-12 0:58 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121211.134310.1757064654502486858.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).