* [PATCH net-next] net: gro: avoid double copy in skb_gro_receive()
@ 2012-12-11 18:38 Eric Dumazet
2012-12-11 18:45 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2012-12-11 18:38 UTC (permalink / raw)
To: David Miller; +Cc: netdev
From: Eric Dumazet <edumazet@google.com>
__copy_skb_header(nskb, p) already copied p->cb[], no need to copy
it again.
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
net/core/skbuff.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index ccbabf5..ac9e44a 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -3028,7 +3028,6 @@ int skb_gro_receive(struct sk_buff **head, struct sk_buff *skb)
memcpy(skb_mac_header(nskb), skb_mac_header(p),
p->data - skb_mac_header(p));
- *NAPI_GRO_CB(nskb) = *NAPI_GRO_CB(p);
skb_shinfo(nskb)->frag_list = p;
skb_shinfo(nskb)->gso_size = pinfo->gso_size;
pinfo->gso_size = 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: gro: avoid double copy in skb_gro_receive()
2012-12-11 18:38 [PATCH net-next] net: gro: avoid double copy in skb_gro_receive() Eric Dumazet
@ 2012-12-11 18:45 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-12-11 18:45 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 11 Dec 2012 10:38:29 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> __copy_skb_header(nskb, p) already copied p->cb[], no need to copy
> it again.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-11 18:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-11 18:38 [PATCH net-next] net: gro: avoid double copy in skb_gro_receive() Eric Dumazet
2012-12-11 18:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).