* [PATCH] tun: allow setting ethernet addresss while running
@ 2012-12-11 1:16 Stephen Hemminger
2012-12-11 17:50 ` David Miller
2012-12-12 3:27 ` Jan Engelhardt
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2012-12-11 1:16 UTC (permalink / raw)
To: davem; +Cc: netdev, jasowang, Stephen Hemminger
This is a pure software device, and ok with live address change.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
drivers/net/tun.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 14a0454..2ac2164 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -849,6 +849,7 @@ static void tun_net_init(struct net_device *dev)
/* Ethernet TAP Device */
ether_setup(dev);
dev->priv_flags &= ~IFF_TX_SKB_SHARING;
+ dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
eth_hw_addr_random(dev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tun: allow setting ethernet addresss while running
2012-12-11 1:16 [PATCH] tun: allow setting ethernet addresss while running Stephen Hemminger
@ 2012-12-11 17:50 ` David Miller
2012-12-12 3:27 ` Jan Engelhardt
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2012-12-11 17:50 UTC (permalink / raw)
To: shemminger; +Cc: netdev, jasowang
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 10 Dec 2012 17:16:00 -0800
> This is a pure software device, and ok with live address change.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tun: allow setting ethernet addresss while running
2012-12-11 1:16 [PATCH] tun: allow setting ethernet addresss while running Stephen Hemminger
2012-12-11 17:50 ` David Miller
@ 2012-12-12 3:27 ` Jan Engelhardt
2012-12-12 16:38 ` Stephen Hemminger
1 sibling, 1 reply; 4+ messages in thread
From: Jan Engelhardt @ 2012-12-12 3:27 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: davem, netdev, jasowang
On Tuesday 2012-12-11 02:16, Stephen Hemminger wrote:
>This is a pure software device, and ok with live address change.
>--- a/drivers/net/tun.c
>+++ b/drivers/net/tun.c
>@@ -849,6 +849,7 @@ static void tun_net_init(struct net_device *dev)
> /* Ethernet TAP Device */
> ether_setup(dev);
> dev->priv_flags &= ~IFF_TX_SKB_SHARING;
>+ dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
>
> eth_hw_addr_random(dev);
Would this possibly apply to L2TP devices as well?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tun: allow setting ethernet addresss while running
2012-12-12 3:27 ` Jan Engelhardt
@ 2012-12-12 16:38 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2012-12-12 16:38 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: davem, netdev, jasowang
On Wed, 12 Dec 2012 04:27:54 +0100 (CET)
Jan Engelhardt <jengelh@inai.de> wrote:
> On Tuesday 2012-12-11 02:16, Stephen Hemminger wrote:
>
> >This is a pure software device, and ok with live address change.
> >--- a/drivers/net/tun.c
> >+++ b/drivers/net/tun.c
> >@@ -849,6 +849,7 @@ static void tun_net_init(struct net_device *dev)
> > /* Ethernet TAP Device */
> > ether_setup(dev);
> > dev->priv_flags &= ~IFF_TX_SKB_SHARING;
> >+ dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
> >
> > eth_hw_addr_random(dev);
>
> Would this possibly apply to L2TP devices as well?
L2TP does not allow changing mac address at all right now.
Only drivers that use eth_mac_addr, can take advantage of the flag.
Looking around here are the other places that could use it.
vxlan, xen-netfront?, gre, gre6, virtio_net?, hyperv?
Also the following look buggy.
c2 allows changing mac address but never tells hardware?
isdn/hysdn_net.c allows setting mac address but then resets it
card value in net_open
xpnet allows setting address but it looks like it fixed by hardware
ipddp allows ethernet address but protocol is not ethernet
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-12-12 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-11 1:16 [PATCH] tun: allow setting ethernet addresss while running Stephen Hemminger
2012-12-11 17:50 ` David Miller
2012-12-12 3:27 ` Jan Engelhardt
2012-12-12 16:38 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).