From: David Miller <davem@davemloft.net>
To: steffen.klassert@secunet.com
Cc: roy.qing.li@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] xfrm: do not check x->km.state
Date: Thu, 13 Dec 2012 14:19:22 -0500 (EST) [thread overview]
Message-ID: <20121213.141922.2249665409902614569.davem@davemloft.net> (raw)
In-Reply-To: <20121213101948.GG18940@secunet.com>
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Thu, 13 Dec 2012 11:19:48 +0100
> On Thu, Dec 13, 2012 at 05:06:00PM +0800, roy.qing.li@gmail.com wrote:
>> From: Li RongQing <roy.qing.li@gmail.com>
>>
>> do not check x->km.state, it will be checked by succedent
>> xfrm_state_check_expire()
>>
>> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
...
> This would remove the only place where the LINUX_MIB_XFRMINSTATEINVALID
> statistics counter is incremented. I think it would be better to ensure
> a valid state before we call xfrm_state_check_expire(). This would make
> the statistics more accurate and we can remove the x->km.state check
> from xfrm_state_check_expire().
Agreed.
next prev parent reply other threads:[~2012-12-13 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 9:06 [PATCH] xfrm: do not check x->km.state roy.qing.li
2012-12-13 10:19 ` Steffen Klassert
2012-12-13 19:19 ` David Miller [this message]
2012-12-14 7:02 ` RongQing Li
2012-12-14 11:45 ` Steffen Klassert
2012-12-15 1:36 ` RongQing Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213.141922.2249665409902614569.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).