From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: djduanjiong@gmail.com, steffen.klassert@secunet.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] ipv6: Change skb->data before using icmpv6_notify() to propagate redirect
Date: Thu, 13 Dec 2012 14:50:28 -0500 (EST) [thread overview]
Message-ID: <20121213.145028.509906659453424680.davem@davemloft.net> (raw)
In-Reply-To: <1355427432.13796.43.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Thu, 13 Dec 2012 11:37:12 -0800
> On Thu, 2012-12-13 at 12:59 -0500, David Miller wrote:
>> > + hdr = (u8 *)ndopts.nd_opts_rh;
>>
>> (u8 *)[SPACE]ndopts...
>
> Really?
>
> checkpatch bleats a --strict message:
>
> CHECK: No space is necessary after a cast
> #5: FILE: t.c:5:
> +
> + bar = *(int *) foo;
Ho hum, I'm actually ambivalent about this so...
next prev parent reply other threads:[~2012-12-13 19:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 11:21 [PATCH v2] ipv6: Change skb->data before using icmpv6_notify() to propagate redirect Duan Jiong
2012-12-13 17:59 ` David Miller
2012-12-13 19:37 ` Joe Perches
2012-12-13 19:50 ` David Miller [this message]
2012-12-14 4:07 ` [PATCH] ndisc: Use more standard logging styles Joe Perches
2012-12-14 4:11 ` Joe Perches
2012-12-14 4:23 ` [PATCH V2] " Joe Perches
2012-12-14 13:58 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213.145028.509906659453424680.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=djduanjiong@gmail.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).