netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* remove noisy message from llcp_sock_sendmsg
@ 2012-12-13  4:11 Dave Jones
  2012-12-13 18:01 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2012-12-13  4:11 UTC (permalink / raw)
  To: netdev

This is easily triggerable when fuzz-testing as an unprivileged user.
We could rate-limit it, but given we don't print similar messages
for other protocols, I just removed it.

Signed-off-by: Dave Jones <davej@redhat.com>

diff --git a/net/nfc/llcp/sock.c b/net/nfc/llcp/sock.c
index 0fa1e92..fea22eb 100644
--- a/net/nfc/llcp/sock.c
+++ b/net/nfc/llcp/sock.c
@@ -614,10 +614,6 @@ static int llcp_sock_sendmsg(struct kiocb *iocb, struct socket *sock,
 
 		if (msg->msg_namelen < sizeof(*addr)) {
 			release_sock(sk);
-
-			pr_err("Invalid socket address length %d\n",
-			       msg->msg_namelen);
-
 			return -EINVAL;
 		}
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: remove noisy message from llcp_sock_sendmsg
  2012-12-13  4:11 remove noisy message from llcp_sock_sendmsg Dave Jones
@ 2012-12-13 18:01 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-12-13 18:01 UTC (permalink / raw)
  To: davej; +Cc: netdev

From: Dave Jones <davej@redhat.com>
Date: Wed, 12 Dec 2012 23:11:34 -0500

> This is easily triggerable when fuzz-testing as an unprivileged user.
> We could rate-limit it, but given we don't print similar messages
> for other protocols, I just removed it.
> 
> Signed-off-by: Dave Jones <davej@redhat.com>

Applied.

Please provide appropriate "xxx: " prefixes in your subject lines
for patch submissions.  "nfc: " would have been appropriate for
this one.

Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-12-13 18:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-13  4:11 remove noisy message from llcp_sock_sendmsg Dave Jones
2012-12-13 18:01 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).