From: Stephen Hemminger <shemminger@vyatta.com>
To: Ang Way Chuang <wcang@sfc.wide.ad.jp>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH] bridge: Bug fix for incorrect interpretation of MLDv2 maximum response code
Date: Thu, 13 Dec 2012 16:12:01 -0800 [thread overview]
Message-ID: <20121213161201.6d2da433@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <50CA6DA5.1020101@sfc.wide.ad.jp>
On Fri, 14 Dec 2012 08:07:01 +0800
Ang Way Chuang <wcang@sfc.wide.ad.jp> wrote:
> This patch fixes the incorrect interpretation of endianness of MLDv2 maximum response
> code within bridge's multicast snooping code.
>
> Signed-off-by: Ang Way Chuang <wcang@sfc.wide.ad.jp>
> ---
> diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> index 977c3ee..29c6283 100644
> --- a/net/bridge/br_multicast.c
> +++ b/net/bridge/br_multicast.c
> @@ -1172,7 +1172,7 @@ static int br_ip6_multicast_query(struct net_bridge *br,
> mld2q = (struct mld2_query *)icmp6_hdr(skb);
> if (!mld2q->mld2q_nsrcs)
> group = &mld2q->mld2q_mca;
> - max_delay = mld2q->mld2q_mrc ? MLDV2_MRC(mld2q->mld2q_mrc) : 1;
> + max_delay = mld2q->mld2q_mrc ? MLDV2_MRC(ntohs(mld2q->mld2q_mrc)) : 1;
> }
>
> if (!group)
Already fixed as part of my patch to fix sparse warnings.
next prev parent reply other threads:[~2012-12-14 0:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 0:07 [PATCH] bridge: Bug fix for incorrect interpretation of MLDv2 maximum response code Ang Way Chuang
2012-12-14 0:12 ` Stephen Hemminger [this message]
2012-12-14 0:19 ` Ang Way Chuang
2012-12-14 0:23 ` Stephen Hemminger
2012-12-14 0:35 ` Ang Way Chuang
2012-12-14 0:51 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213161201.6d2da433@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=wcang@sfc.wide.ad.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).