From: David Miller <davem@davemloft.net>
To: mkl@pengutronix.de
Cc: netdev@vger.kernel.org, linux-can@vger.kernel.org,
sfr@canb.auug.org.au, andreas@gaisler.com
Subject: Re: [PATCH] can: sja1000: fix compilation on x86
Date: Fri, 14 Dec 2012 16:37:58 -0500 (EST) [thread overview]
Message-ID: <20121214.163758.465958297963655994.davem@davemloft.net> (raw)
In-Reply-To: <1355520824-23175-2-git-send-email-mkl@pengutronix.de>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Fri, 14 Dec 2012 22:33:44 +0100
> @@ -121,7 +121,7 @@ static int sja1000_ofp_probe(struct platform_device *ofdev)
> }
>
> irq = irq_of_parse_and_map(np, 0);
> - if (irq == NO_IRQ) {
> + if (irq <= 0) {
> dev_err(&ofdev->dev, "no irq found\n");
> err = -ENODEV;
> goto exit_unmap_mem;
I don't see anything existing which says this is the proper
transformation.
There is no consistency at all for the tests of the return
value of irq_of_parse_and_map().
And if anything testing against zero is the correct thing to
do, universally.
I'm not applying this or pulling from your tree, sorry.
next prev parent reply other threads:[~2012-12-14 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 21:33 pull-request: can 2012-12-14 Marc Kleine-Budde
2012-12-14 21:33 ` [PATCH] can: sja1000: fix compilation on x86 Marc Kleine-Budde
2012-12-14 21:37 ` David Miller [this message]
2012-12-14 22:17 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121214.163758.465958297963655994.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andreas@gaisler.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).