From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: torvalds@linux-foundation.org, netdev@vger.kernel.org,
vyasevich@gmail.com, linux-sctp@vger.kernel.org
Subject: Re: [PATCH] sctp: Change defaults on cookie hmac selection
Date: Fri, 14 Dec 2012 20:14:26 -0500 (EST) [thread overview]
Message-ID: <20121214.201426.1300133389027142871.davem@davemloft.net> (raw)
In-Reply-To: <20121215011229.GD10508@neilslaptop.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Fri, 14 Dec 2012 20:12:29 -0500
> On Fri, Dec 14, 2012 at 04:44:56PM -0800, Linus Torvalds wrote:
>> On Fri, Dec 14, 2012 at 4:38 PM, Neil Horman <nhorman@tuxdriver.com> wrote:
>> >
>> > No need, I think. Since its a user configurable choice now, the user can just
>> > set the selector to "None" in proc, and none will be used.
>>
>> Well, by the same logic, there's no point to defaulting to MD5 either,
>> since the user could just put MD5 in the there.
>>
>> The point is, if you're asking for a default, you should include the
>> actual choices, and not limit it to some random subset of choices. No?
>>
>> Linus
>>
> Ok, Thats a fair point, I can add a option to choose the "None" option as the
> deafult. Dave, do you want a delta patch, or a new version?
New version please.
next prev parent reply other threads:[~2012-12-15 1:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 18:51 [PATCH] sctp: Change defaults on cookie hmac selection Neil Horman
2012-12-14 20:01 ` Vlad Yasevich
2012-12-14 21:56 ` Linus Torvalds
2012-12-15 0:38 ` Neil Horman
2012-12-15 0:44 ` Linus Torvalds
2012-12-15 1:12 ` Neil Horman
2012-12-15 1:14 ` David Miller [this message]
2012-12-15 1:22 ` [PATCH v2] " Neil Horman
2012-12-16 1:16 ` David Miller
2013-01-07 13:25 ` Florian Fainelli
2013-01-07 14:49 ` Neil Horman
2013-01-07 15:15 ` Florian Fainelli
2013-01-07 15:38 ` Neil Horman
2013-01-07 15:48 ` Vlad Yasevich
2013-01-08 17:36 ` Florian Fainelli
2013-01-07 15:32 ` Vlad Yasevich
2013-01-07 15:46 ` Neil Horman
2013-01-07 16:39 ` Vlad Yasevich
2013-01-08 17:48 ` Florian Fainelli
2013-01-08 18:08 ` Vlad Yasevich
2013-01-08 18:20 ` Alex Elder
2013-01-08 18:28 ` Vlad Yasevich
2013-01-09 9:08 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121214.201426.1300133389027142871.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=torvalds@linux-foundation.org \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).