From: Steffen Klassert <steffen.klassert@secunet.com>
To: RongQing Li <roy.qing.li@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] xfrm: do not check x->km.state
Date: Fri, 14 Dec 2012 12:45:45 +0100 [thread overview]
Message-ID: <20121214114545.GI18940@secunet.com> (raw)
In-Reply-To: <CAJFZqHxZDAeZxLyxddtxCB6ucU6hMxH1TtWcMD2TZGRRA52-_g@mail.gmail.com>
On Fri, Dec 14, 2012 at 03:02:32PM +0800, RongQing Li wrote:
>
> since xfrm_output_one() calls xfrm_state_check_expire() too, but without
> checking (x->km.state != XFRM_STATE_VALID), I think we can not directly
> remove the check of km.state from xfrm_state_check_expire(). I have two
> option, which one do you think it is better?
>
> 1. remove this check in xfrm_state_check_expire, and add a check in
> xfrm_output_one
>
I think the first option ist the better one. It removes a superfluous
check and we get some more statistics.
next prev parent reply other threads:[~2012-12-14 11:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 9:06 [PATCH] xfrm: do not check x->km.state roy.qing.li
2012-12-13 10:19 ` Steffen Klassert
2012-12-13 19:19 ` David Miller
2012-12-14 7:02 ` RongQing Li
2012-12-14 11:45 ` Steffen Klassert [this message]
2012-12-15 1:36 ` RongQing Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121214114545.GI18940@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).