From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, torvalds@linux-foundation.org,
vyasevich@gmail.com, linux-sctp@vger.kernel.org
Subject: Re: [PATCH v2] sctp: Change defaults on cookie hmac selection
Date: Sat, 15 Dec 2012 17:16:20 -0800 (PST) [thread overview]
Message-ID: <20121215.171620.1992551971037225064.davem@davemloft.net> (raw)
In-Reply-To: <1355534521-32719-1-git-send-email-nhorman@tuxdriver.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Fri, 14 Dec 2012 20:22:01 -0500
> Recently I posted commit 3c68198e75 which made selection of the cookie hmac
> algorithm selectable. This is all well and good, but Linus noted that it
> changes the default config:
> http://marc.info/?l=linux-netdev&m=135536629004808&w=2
>
> I've modified the sctp Kconfig file to reflect the recommended way of making
> this choice, using the thermal driver example specified, and brought the
> defaults back into line with the way they were prior to my origional patch
>
> Also, on Linus' suggestion, re-adding ability to select default 'none' hmac
> algorithm, so we don't needlessly bloat the kernel by forcing a non-none
> default. This also led me to note that we won't honor the default none
> condition properly because of how sctp_net_init is encoded. Fix that up as
> well.
>
> Tested by myself (allbeit fairly quickly). All configuration combinations seems
> to work soundly.
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Applied.
next prev parent reply other threads:[~2012-12-16 1:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 18:51 [PATCH] sctp: Change defaults on cookie hmac selection Neil Horman
2012-12-14 20:01 ` Vlad Yasevich
2012-12-14 21:56 ` Linus Torvalds
2012-12-15 0:38 ` Neil Horman
2012-12-15 0:44 ` Linus Torvalds
2012-12-15 1:12 ` Neil Horman
2012-12-15 1:14 ` David Miller
2012-12-15 1:22 ` [PATCH v2] " Neil Horman
2012-12-16 1:16 ` David Miller [this message]
2013-01-07 13:25 ` Florian Fainelli
2013-01-07 14:49 ` Neil Horman
2013-01-07 15:15 ` Florian Fainelli
2013-01-07 15:38 ` Neil Horman
2013-01-07 15:48 ` Vlad Yasevich
2013-01-08 17:36 ` Florian Fainelli
2013-01-07 15:32 ` Vlad Yasevich
2013-01-07 15:46 ` Neil Horman
2013-01-07 16:39 ` Vlad Yasevich
2013-01-08 17:48 ` Florian Fainelli
2013-01-08 18:08 ` Vlad Yasevich
2013-01-08 18:20 ` Alex Elder
2013-01-08 18:28 ` Vlad Yasevich
2013-01-09 9:08 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121215.171620.1992551971037225064.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=torvalds@linux-foundation.org \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).