* [PATCH net] sctp: jsctp_sf_eat_sack: fix jprobes function signature mismatch
[not found] <cover.1355602097.git.dborkman@redhat.com>
@ 2012-12-15 20:12 ` Daniel Borkmann
2012-12-15 20:39 ` Vlad Yasevich
2012-12-16 1:17 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Borkmann @ 2012-12-15 20:12 UTC (permalink / raw)
To: David Miller; +Cc: Vlad Yasevich, netdev
Commit 24cb81a6a (sctp: Push struct net down into all of the
state machine functions) introduced the net structure into all
state machine functions, but jsctp_sf_eat_sack was not updated,
hence when SCTP association probing is enabled in the kernel,
any simple SCTP client/server program from userspace will panic
the kernel.
Cc: Vlad Yasevich <vyasevich@gmail.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
---
net/sctp/probe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/sctp/probe.c b/net/sctp/probe.c
index bc6cd75..5f7518d 100644
--- a/net/sctp/probe.c
+++ b/net/sctp/probe.c
@@ -122,7 +122,8 @@ static const struct file_operations sctpprobe_fops = {
.llseek = noop_llseek,
};
-sctp_disposition_t jsctp_sf_eat_sack(const struct sctp_endpoint *ep,
+sctp_disposition_t jsctp_sf_eat_sack(struct net *net,
+ const struct sctp_endpoint *ep,
const struct sctp_association *asoc,
const sctp_subtype_t type,
void *arg,
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] sctp: jsctp_sf_eat_sack: fix jprobes function signature mismatch
2012-12-15 20:12 ` [PATCH net] sctp: jsctp_sf_eat_sack: fix jprobes function signature mismatch Daniel Borkmann
@ 2012-12-15 20:39 ` Vlad Yasevich
2012-12-15 21:02 ` Daniel Borkmann
2012-12-16 1:17 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Vlad Yasevich @ 2012-12-15 20:39 UTC (permalink / raw)
To: Daniel Borkmann; +Cc: David Miller, netdev
On 12/15/2012 03:12 PM, Daniel Borkmann wrote:
> Commit 24cb81a6a (sctp: Push struct net down into all of the
> state machine functions) introduced the net structure into all
> state machine functions, but jsctp_sf_eat_sack was not updated,
> hence when SCTP association probing is enabled in the kernel,
> any simple SCTP client/server program from userspace will panic
> the kernel.
Aha!!! That makes a lot more sense...
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Thanks
-vlad
>
> Cc: Vlad Yasevich <vyasevich@gmail.com>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> ---
> net/sctp/probe.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/sctp/probe.c b/net/sctp/probe.c
> index bc6cd75..5f7518d 100644
> --- a/net/sctp/probe.c
> +++ b/net/sctp/probe.c
> @@ -122,7 +122,8 @@ static const struct file_operations sctpprobe_fops = {
> .llseek = noop_llseek,
> };
>
> -sctp_disposition_t jsctp_sf_eat_sack(const struct sctp_endpoint *ep,
> +sctp_disposition_t jsctp_sf_eat_sack(struct net *net,
> + const struct sctp_endpoint *ep,
> const struct sctp_association *asoc,
> const sctp_subtype_t type,
> void *arg,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] sctp: jsctp_sf_eat_sack: fix jprobes function signature mismatch
2012-12-15 20:39 ` Vlad Yasevich
@ 2012-12-15 21:02 ` Daniel Borkmann
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2012-12-15 21:02 UTC (permalink / raw)
To: Vlad Yasevich; +Cc: David Miller, netdev
On Sat, Dec 15, 2012 at 9:39 PM, Vlad Yasevich <vyasevich@gmail.com> wrote:
> On 12/15/2012 03:12 PM, Daniel Borkmann wrote:
>>
>> Commit 24cb81a6a (sctp: Push struct net down into all of the
>> state machine functions) introduced the net structure into all
>> state machine functions, but jsctp_sf_eat_sack was not updated,
>> hence when SCTP association probing is enabled in the kernel,
>> any simple SCTP client/server program from userspace will panic
>> the kernel.
>
>
> Aha!!! That makes a lot more sense...
Indeed. ;-)
> Acked-by: Vlad Yasevich <vyasevich@gmail.com>
>
> Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] sctp: jsctp_sf_eat_sack: fix jprobes function signature mismatch
2012-12-15 20:12 ` [PATCH net] sctp: jsctp_sf_eat_sack: fix jprobes function signature mismatch Daniel Borkmann
2012-12-15 20:39 ` Vlad Yasevich
@ 2012-12-16 1:17 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2012-12-16 1:17 UTC (permalink / raw)
To: dborkman; +Cc: vyasevich, netdev
From: Daniel Borkmann <dborkman@redhat.com>
Date: Sat, 15 Dec 2012 21:12:43 +0100
> Commit 24cb81a6a (sctp: Push struct net down into all of the
> state machine functions) introduced the net structure into all
> state machine functions, but jsctp_sf_eat_sack was not updated,
> hence when SCTP association probing is enabled in the kernel,
> any simple SCTP client/server program from userspace will panic
> the kernel.
>
> Cc: Vlad Yasevich <vyasevich@gmail.com>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-12-16 1:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1355602097.git.dborkman@redhat.com>
2012-12-15 20:12 ` [PATCH net] sctp: jsctp_sf_eat_sack: fix jprobes function signature mismatch Daniel Borkmann
2012-12-15 20:39 ` Vlad Yasevich
2012-12-15 21:02 ` Daniel Borkmann
2012-12-16 1:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).