From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: danborkmann@iogearbox.net, kirill@shutemov.name,
maxk@qti.qualcomm.com, netdev@vger.kernel.org,
dwmw2@infradead.org
Subject: Re: [PATCH] tuntap: reset network header before calling skb_get_rxhash()
Date: Mon, 17 Dec 2012 12:33:11 -0800 (PST) [thread overview]
Message-ID: <20121217.123311.1003355345453159139.davem@davemloft.net> (raw)
In-Reply-To: <1355755160.10504.25.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 17 Dec 2012 06:39:20 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Commit 499744209b2c (tuntap: dont use skb after netif_rx_ni(skb))
> introduced another bug.
>
> skb_get_rxhash() needs to access the network header, and it was
> set for us in netif_rx_ni().
>
> We need to reset network header or else skb_flow_dissect() behavior
> is out of control.
>
> Reported-and-tested-by: Kirill A. Shutemov <kirill@shutemov.name>
> Tested-by: Daniel Borkmann <daniel.borkmann@tik.ee.ethz.ch>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, hopefully we've really resolved this fully now :)
prev parent reply other threads:[~2012-12-17 20:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 0:56 openconnect triggers soft lockup in __skb_get_rxhash Kirill A. Shutemov
2012-12-17 1:22 ` David Miller
2012-12-17 1:46 ` Kirill A. Shutemov
2012-12-17 4:46 ` Eric Dumazet
2012-12-17 8:11 ` Kirill A. Shutemov
2012-12-17 13:38 ` Daniel Borkmann
2012-12-17 14:39 ` [PATCH] tuntap: reset network header before calling skb_get_rxhash() Eric Dumazet
2012-12-17 20:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217.123311.1003355345453159139.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=danborkmann@iogearbox.net \
--cc=dwmw2@infradead.org \
--cc=eric.dumazet@gmail.com \
--cc=kirill@shutemov.name \
--cc=maxk@qti.qualcomm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).