* [PATCH] tuntap: fix sparse warning
@ 2012-12-18 3:00 Jason Wang
2012-12-18 4:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2012-12-18 3:00 UTC (permalink / raw)
To: davem, netdev, linux-kernel; +Cc: fengguang.wu, Jason Wang
Make tun_enable_queue() static to fix the sparse warning:
drivers/net/tun.c:399:19: sparse: symbol 'tun_enable_queue' was not declared. Should it be static?
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/net/tun.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 173acf5..504f7f1 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -396,7 +396,7 @@ static void tun_disable_queue(struct tun_struct *tun, struct tun_file *tfile)
++tun->numdisabled;
}
-struct tun_struct *tun_enable_queue(struct tun_file *tfile)
+static struct tun_struct *tun_enable_queue(struct tun_file *tfile)
{
struct tun_struct *tun = tfile->detached;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tuntap: fix sparse warning
2012-12-18 3:00 [PATCH] tuntap: fix sparse warning Jason Wang
@ 2012-12-18 4:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-12-18 4:49 UTC (permalink / raw)
To: jasowang; +Cc: netdev, linux-kernel, fengguang.wu
From: Jason Wang <jasowang@redhat.com>
Date: Tue, 18 Dec 2012 11:00:27 +0800
> Make tun_enable_queue() static to fix the sparse warning:
>
> drivers/net/tun.c:399:19: sparse: symbol 'tun_enable_queue' was not declared. Should it be static?
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-18 4:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-18 3:00 [PATCH] tuntap: fix sparse warning Jason Wang
2012-12-18 4:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).