From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Eric Dumazet <erdnetdev@gmail.com>
Cc: David Miller <davem@davemloft.net>,
maxk@qti.qualcomm.com, netdev@vger.kernel.org,
dwmw2@infradead.org
Subject: Re: openconnect triggers soft lockup in __skb_get_rxhash
Date: Mon, 17 Dec 2012 10:11:21 +0200 [thread overview]
Message-ID: <20121217081121.GA24173@shutemov.name> (raw)
In-Reply-To: <1355719589.10504.13.camel@edumazet-glaptop>
On Sun, Dec 16, 2012 at 08:46:29PM -0800, Eric Dumazet wrote:
> On Mon, 2012-12-17 at 03:46 +0200, Kirill A. Shutemov wrote:
> > On Sun, Dec 16, 2012 at 05:22:14PM -0800, David Miller wrote:
> > >
> > > Already fixed in Linus's tree by:
> > >
> > > From 499744209b2cbca66c42119226e5470da3bb7040 Mon Sep 17 00:00:00 2001
> >
> > No, it's not. I use up-to-date (2a74dbb) Linus tree with the patch in and
> > still see the issue.
> >
>
> Coud you try the following one liner ?
Works for me. So far no problems.
Reported-and-tested-by: Kirill A. Shutemov <kirill@shutemov.name>
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 255a9f5..173acf5 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -1199,6 +1199,7 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
> skb_shinfo(skb)->tx_flags |= SKBTX_DEV_ZEROCOPY;
> }
>
> + skb_reset_network_header(skb);
> rxhash = skb_get_rxhash(skb);
> netif_rx_ni(skb);
>
>
>
--
Kirill A. Shutemov
next prev parent reply other threads:[~2012-12-17 8:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 0:56 openconnect triggers soft lockup in __skb_get_rxhash Kirill A. Shutemov
2012-12-17 1:22 ` David Miller
2012-12-17 1:46 ` Kirill A. Shutemov
2012-12-17 4:46 ` Eric Dumazet
2012-12-17 8:11 ` Kirill A. Shutemov [this message]
2012-12-17 13:38 ` Daniel Borkmann
2012-12-17 14:39 ` [PATCH] tuntap: reset network header before calling skb_get_rxhash() Eric Dumazet
2012-12-17 20:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217081121.GA24173@shutemov.name \
--to=kirill@shutemov.name \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=erdnetdev@gmail.com \
--cc=maxk@qti.qualcomm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).