From: Sascha Hauer <s.hauer@pengutronix.de>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Frank Li <lznuaa@gmail.com>, Frank Li <Frank.Li@freescale.com>,
lznua@gmail.com, richardcochran@gmail.com,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
davem@davemloft.net
Subject: Re: [PATCH 4/4] FEC: Add time stamping code and a PTP hardware clock
Date: Mon, 17 Dec 2012 21:02:32 +0100 [thread overview]
Message-ID: <20121217200232.GS26326@pengutronix.de> (raw)
In-Reply-To: <20121217151445.GA17907@S2101-09.ap.freescale.net>
On Mon, Dec 17, 2012 at 11:14:46PM +0800, Shawn Guo wrote:
> Hi Sascha,
>
> On Mon, Dec 17, 2012 at 10:48:31PM +0800, Frank Li wrote:
> > > I don't know how to continue from here. Since the whole patch doesn't
> > > seem to reviewed very much I tend to say we should revert it for now and
> > > let Frank redo it for the next merge window.
> > >
> > > Other opinions?
> >
> > Can we just disable CONFIG_FEC_PTP defaut instead of revert whole patch?
> >
> To be clear, the following is what Frank meant. Since Frank is out of
> office for some time, I will send this immediate fix to David, if you
> are fine with it.
This leaves an option in the tree which can be used to break FEC on
i.MX3/5.
depends on !SOC_IMX31 && !SOC_IMX35 && !SOC_IMX5
might be an option, but given that this patch seems to have bypassed any
review I feel more like reverting it.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-12-17 20:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 4:25 [PATCH 4/4] FEC: Add time stamping code and a PTP hardware clock Frank Li
2012-11-02 9:19 ` Richard Cochran
2012-11-06 1:36 ` Frank Li
2012-12-17 9:13 ` Sascha Hauer
2012-12-17 14:48 ` Frank Li
2012-12-17 15:14 ` Shawn Guo
2012-12-17 20:02 ` Sascha Hauer [this message]
2012-12-18 7:04 ` Richard Cochran
2012-12-18 8:51 ` Frank Li
2012-12-19 15:53 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217200232.GS26326@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=Frank.Li@freescale.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lznua@gmail.com \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).