From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] xfrm: removes a superfluous check and add a statistic Date: Tue, 18 Dec 2012 15:38:27 -0800 (PST) Message-ID: <20121218.153827.489159369320523507.davem@davemloft.net> References: <1355819949-30429-1-git-send-email-roy.qing.li@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: roy.qing.li@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:37365 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753932Ab2LRXia (ORCPT ); Tue, 18 Dec 2012 18:38:30 -0500 In-Reply-To: <1355819949-30429-1-git-send-email-roy.qing.li@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: roy.qing.li@gmail.com Date: Tue, 18 Dec 2012 16:39:09 +0800 > From: Li RongQing > > Remove the check if x->km.state equal to XFRM_STATE_VALID in > xfrm_state_check_expire(), which will be done before call > xfrm_state_check_expire(). > > add a LINUX_MIB_XFRMOUTSTATEINVALID statistic to record the > outbound error due to invalid xfrm state. > > Signed-off-by: Li RongQing Please add new statistic SNMP mib numbers to the end of the enumeration, rather than in the middle. Thanks.