netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Frank Li <Frank.Li@freescale.com>,
	netdev@vger.kernel.org, lznua@gmail.com,
	Frank Li <lznuaa@gmail.com>, Shawn Guo <shawn.guo@linaro.org>,
	davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] FEC: Add time stamping code and a PTP hardware clock
Date: Tue, 18 Dec 2012 08:04:20 +0100	[thread overview]
Message-ID: <20121218070420.GA2946@netboy.at.omicron.at> (raw)
In-Reply-To: <20121217200232.GS26326@pengutronix.de>

On Mon, Dec 17, 2012 at 09:02:32PM +0100, Sascha Hauer wrote:
> This leaves an option in the tree which can be used to break FEC on
> i.MX3/5.
> 
> 	depends on !SOC_IMX31 && !SOC_IMX35 && !SOC_IMX5
> 
> might be an option, but given that this patch seems to have bypassed any
> review I feel more like reverting it.

Instead of reverting, I suggest finding a solution (Frank) to let the
code work when it can work and to prevent it when it cannot. This
could be kconfig, DT, or run time probing of silicon revisions, but I
don't have access to this hardware, and so I can't really say how to
fix it.

Just for the record, I did in fact review this patch, and I commented
on exactly this point. Frank said we would address this point, and he
did so. Not knowing the imx family very well, I took his word for it.
After all, Frank has a Freescale address, and I would expect a
Freescale employee to know how to provide the right fix.

Thanks,
Richard

  reply	other threads:[~2012-12-18  7:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31  4:25 [PATCH 4/4] FEC: Add time stamping code and a PTP hardware clock Frank Li
2012-11-02  9:19 ` Richard Cochran
2012-11-06  1:36   ` Frank Li
2012-12-17  9:13 ` Sascha Hauer
2012-12-17 14:48   ` Frank Li
2012-12-17 15:14     ` Shawn Guo
2012-12-17 20:02       ` Sascha Hauer
2012-12-18  7:04         ` Richard Cochran [this message]
2012-12-18  8:51           ` Frank Li
2012-12-19 15:53           ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121218070420.GA2946@netboy.at.omicron.at \
    --to=richardcochran@gmail.com \
    --cc=Frank.Li@freescale.com \
    --cc=davem@davemloft.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lznua@gmail.com \
    --cc=lznuaa@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).