From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH] net: fec: forbid FEC_PTP on SoCs that do not support Date: Tue, 18 Dec 2012 21:12:01 +0800 Message-ID: <20121218131159.GA16251@S2101-09.ap.freescale.net> References: <1355836004-22067-1-git-send-email-shawn.guo@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Sascha Hauer , Richard Cochran , "David S. Miller" , Frank Li , To: Return-path: Received: from co1ehsobe002.messaging.microsoft.com ([216.32.180.185]:14236 "EHLO co1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754708Ab2LRNLu (ORCPT ); Tue, 18 Dec 2012 08:11:50 -0500 Content-Disposition: inline In-Reply-To: <1355836004-22067-1-git-send-email-shawn.guo@linaro.org> Sender: netdev-owner@vger.kernel.org List-ID: Misspelled Frank's email address. Copy him. Sorry. On Tue, Dec 18, 2012 at 09:06:44PM +0800, Shawn Guo wrote: > Beside imx6q, the kernel built from imx_v6_v7_defconfig is also > supposed to be running on other IMX SoCs that do not have the PTP > block. Before fec driver gets fixed to run-time detect target hardware > rather than conditional compiling with #ifdef CONFIG_FEC_PTP, let's > give it a quick fix in Kconfig to forbid FEC_PTP on those IMX SoCs that > do not support PTP. > > Reported-by: Sascha Hauer > Signed-off-by: Shawn Guo > --- > drivers/net/ethernet/freescale/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig > index 5ba6e1c..ec490d7 100644 > --- a/drivers/net/ethernet/freescale/Kconfig > +++ b/drivers/net/ethernet/freescale/Kconfig > @@ -94,9 +94,8 @@ config GIANFAR > > config FEC_PTP > bool "PTP Hardware Clock (PHC)" > - depends on FEC && ARCH_MXC > + depends on FEC && ARCH_MXC && !SOC_IMX25 && !SOC_IMX27 && !SOC_IMX35 && !SOC_IMX5 > select PTP_1588_CLOCK > - default y if SOC_IMX6Q > --help--- > Say Y here if you want to use PTP Hardware Clock (PHC) in the > driver. Only the basic clock operations have been implemented. > -- > 1.7.9.5 > >