From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chas Williams <chas@cmf.nrl.navy.mil>,
Nathan Williams <nathan@traverse.com.au>,
David Woodhouse <David.Woodhouse@intel.com>
Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
kbuild@01.org
Subject: [patch] solos-pci: double lock in geos_gpio_store()
Date: Thu, 20 Dec 2012 10:48:45 +0300 [thread overview]
Message-ID: <20121220074845.GA14716@elgon.mountain> (raw)
In-Reply-To: <50d25b88.0QAOhrb1a/eK/hR1%fengguang.wu@intel.com>
There is a typo here so we do a double lock instead of an unlock.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Only needed in linux-next. Introduced in f9baad02e7411d9 [14/17]
solos-pci: add GPIO support for newer versions on Geos board
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 473d808..7b95736 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -531,7 +531,7 @@ static ssize_t geos_gpio_store(struct device *dev, struct device_attribute *attr
} else {
count = -EINVAL;
}
- spin_lock_irq(&card->param_queue_lock);
+ spin_unlock_irq(&card->param_queue_lock);
return count;
}
next parent reply other threads:[~2012-12-20 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50d25b88.0QAOhrb1a/eK/hR1%fengguang.wu@intel.com>
2012-12-20 7:48 ` Dan Carpenter [this message]
2012-12-20 9:22 ` [patch] solos-pci: double lock in geos_gpio_store() Woodhouse, David
2012-12-21 21:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220074845.GA14716@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=David.Woodhouse@intel.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=kbuild@01.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=nathan@traverse.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).