From: Stephen Hemminger <shemminger@vyatta.com>
To: Yan Burman <yanb@mellanox.com>
Cc: netdev@vger.kernel.org, ogerlitz@mellanox.com
Subject: Re: [PATCH net] net/vxlan: Use the underlying device index when joining/leaving multicast groups
Date: Thu, 20 Dec 2012 08:26:08 -0800 [thread overview]
Message-ID: <20121220082608.498b8741@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1356010568-21644-1-git-send-email-yanb@mellanox.com>
On Thu, 20 Dec 2012 15:36:08 +0200
Yan Burman <yanb@mellanox.com> wrote:
> The socket calls from vxlan to join/leave multicast group aren't
> using the index of the underlying device, as a result the stack uses
> the first interface that is up. This results in vxlan being non functional
> over a device which isn't the 1st to be up.
> Fix this by providing the iflink field to the vxlan instance
> to the multicast calls.
>
> Signed-off-by: Yan Burman <yanb@mellanox.com>
> ---
> drivers/net/vxlan.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 3b3fdf6..40f2cc1 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -505,7 +505,8 @@ static int vxlan_join_group(struct net_device *dev)
> struct vxlan_net *vn = net_generic(dev_net(dev), vxlan_net_id);
> struct sock *sk = vn->sock->sk;
> struct ip_mreqn mreq = {
> - .imr_multiaddr.s_addr = vxlan->gaddr,
> + .imr_multiaddr.s_addr = vxlan->gaddr,
> + .imr_ifindex = vxlan->link,
> };
> int err;
>
> @@ -532,7 +533,8 @@ static int vxlan_leave_group(struct net_device *dev)
> int err = 0;
> struct sock *sk = vn->sock->sk;
> struct ip_mreqn mreq = {
> - .imr_multiaddr.s_addr = vxlan->gaddr,
> + .imr_multiaddr.s_addr = vxlan->gaddr,
> + .imr_ifindex = vxlan->link,
> };
>
> /* Only leave group when last vxlan is done. */
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
next prev parent reply other threads:[~2012-12-20 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 13:36 [PATCH net] net/vxlan: Use the underlying device index when joining/leaving multicast groups Yan Burman
2012-12-20 16:26 ` Stephen Hemminger [this message]
2012-12-26 23:10 ` David Miller
[not found] ` <20130114004652.GA11597@fliwatuet.svr02.mucip.net>
2013-01-17 15:19 ` Yan Burman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220082608.498b8741@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yanb@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox