From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: Vlad Yasevich <vyasevic@redhat.com>
Cc: netdev@vger.kernel.org, shemminger@vyatta.com,
davem@davemloft.net, or.gerlitz@gmail.com, jhs@mojatatu.com,
mst@redhat.com, erdnetdev@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH net-next V4 02/13] bridge: Add vlan filtering infrastructure
Date: Thu, 20 Dec 2012 15:39:13 +0200 [thread overview]
Message-ID: <20121220153913.11a10fd0@pixies.home.jungo.com> (raw)
In-Reply-To: <1355939304-21804-3-git-send-email-vyasevic@redhat.com>
Hi Vlad,
On Wed, 19 Dec 2012 12:48:13 -0500 Vlad Yasevich <vyasevic@redhat.com> wrote:
> +static void nbp_vlan_flush(struct net_bridge_port *p)
> +{
> + struct net_port_vlan *pve;
> + struct net_port_vlan *tmp;
> +
> + ASSERT_RTNL();
> +
> + list_for_each_entry_safe(pve, tmp, &p->vlan_list, list)
> + nbp_vlan_delete(p, pve->vid, BRIDGE_FLAGS_SELF);
Why would you want to clear "bridge master port" association from this
vlan, in the event of NBP destruction?
The "bridge port" may still be a member of this vlan, doesn't it?
Seems flags argument should be 0.
> +#define BR_VID_HASH_SIZE (1<<6)
> +#define br_vlan_hash(vid) ((vid) % (BR_VID_HASH_SIZE - 1))
Did you mean: & (BR_VID_HASH_SIZE - 1)
Regards,
Shmulik
next prev parent reply other threads:[~2012-12-20 13:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 17:48 [PATCH net-next V4 00/13] Add basic VLAN support to bridges Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 01/13] vlan: wrap hw-acceleration calls in separate functions Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 02/13] bridge: Add vlan filtering infrastructure Vlad Yasevich
2012-12-20 13:39 ` Shmulik Ladkani [this message]
2012-12-20 15:31 ` Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 03/13] bridge: Validate that vlan is permitted on ingress Vlad Yasevich
2012-12-20 7:27 ` Cong Wang
2012-12-20 14:07 ` Shmulik Ladkani
2012-12-20 15:41 ` Vlad Yasevich
2012-12-20 16:24 ` Shmulik Ladkani
2012-12-20 16:54 ` Vlad Yasevich
2012-12-20 20:13 ` Shmulik Ladkani
2012-12-21 4:48 ` Shmulik Ladkani
2012-12-19 17:48 ` [PATCH net-next V4 04/13] bridge: Verify that a vlan is allowed to egress on give port Vlad Yasevich
2012-12-20 14:28 ` Shmulik Ladkani
2012-12-19 17:48 ` [PATCH net-next V4 05/13] bridge: Cache vlan in the cb for faster egress lookup Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 06/13] bridge: Add vlan to unicast fdb entries Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 07/13] bridge: Add vlan id to multicast groups Vlad Yasevich
2012-12-20 8:05 ` Cong Wang
2012-12-19 17:48 ` [PATCH net-next V4 08/13] bridge: Add netlink interface to configure vlans on bridge ports Vlad Yasevich
2012-12-20 7:48 ` Cong Wang
2012-12-19 17:48 ` [PATCH net-next V4 09/13] bridge: Add vlan support to static neighbors Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 10/13] bridge: Add the ability to configure untagged vlans Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 11/13] bridge: Implement untagged vlan handling Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 12/13] bridge: Dump vlan information from a bridge port Vlad Yasevich
2012-12-19 17:48 ` [PATCH net-next V4 13/13] bridge: Add vlan support for local fdb entries Vlad Yasevich
2012-12-19 22:54 ` [PATCH net-next V4 00/13] Add basic VLAN support to bridges Andrew Collins
2012-12-19 22:58 ` Vlad Yasevich
2012-12-20 10:08 ` Vitalii Demianets
2012-12-20 17:07 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220153913.11a10fd0@pixies.home.jungo.com \
--to=shmulik.ladkani@gmail.com \
--cc=davem@davemloft.net \
--cc=erdnetdev@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=shemminger@vyatta.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).