From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 4/4] net/smsc911x: Provide common clock functionality Date: Thu, 20 Dec 2012 19:24:42 +0000 Message-ID: <20121220192441.GC14363@n2100.arm.linux.org.uk> References: <1355937587-31730-1-git-send-email-lee.jones@linaro.org> <1355937587-31730-4-git-send-email-lee.jones@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Lee Jones , Steve Glendinning , Robert Marklund , linus.walleij@stericsson.com, arnd@arndb.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Linus Walleij Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:35103 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908Ab2LTTYx (ORCPT ); Thu, 20 Dec 2012 14:24:53 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Dec 20, 2012 at 08:12:08PM +0100, Linus Walleij wrote: > On Wed, Dec 19, 2012 at 6:19 PM, Lee Jones wrote: > > > Some platforms provide clocks which require enabling before the > > SMSC911x chip will power on. This patch uses the new common clk > > framework to do just that. If no clock is provided, it will just > > be ignored and the driver will continue to assume that no clock > > is required for the chip to run successfully. > > > > Cc: Steve Glendinning > > Cc: netdev@vger.kernel.org > > Signed-off-by: Lee Jones > > Seems to me like it'll do the trick. > Acked-by: Linus Walleij This looks fairly dangerous. What about those platforms which use this driver, but don't provide a clock for it? It looks like this will result in those platforms losing their ethernet support. There's at least a bunch of the ARM evaluation boards which make use of this driver...