From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 4/4] net/smsc911x: Provide common clock functionality Date: Thu, 20 Dec 2012 20:35:14 +0000 Message-ID: <20121220203514.GN2691@gmail.com> References: <1355937587-31730-1-git-send-email-lee.jones@linaro.org> <1355937587-31730-4-git-send-email-lee.jones@linaro.org> <20121220192441.GC14363@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Linus Walleij , Steve Glendinning , Robert Marklund , linus.walleij@stericsson.com, arnd@arndb.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Russell King - ARM Linux Return-path: Received: from mail-we0-f170.google.com ([74.125.82.170]:32895 "EHLO mail-we0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751666Ab2LTUfT (ORCPT ); Thu, 20 Dec 2012 15:35:19 -0500 Received: by mail-we0-f170.google.com with SMTP id r1so1884460wey.1 for ; Thu, 20 Dec 2012 12:35:18 -0800 (PST) Content-Disposition: inline In-Reply-To: <20121220192441.GC14363@n2100.arm.linux.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 20 Dec 2012, Russell King - ARM Linux wrote: > On Thu, Dec 20, 2012 at 08:12:08PM +0100, Linus Walleij wrote: > > On Wed, Dec 19, 2012 at 6:19 PM, Lee Jones w= rote: > >=20 > > > Some platforms provide clocks which require enabling before the > > > SMSC911x chip will power on. This patch uses the new common clk > > > framework to do just that. If no clock is provided, it will just > > > be ignored and the driver will continue to assume that no clock > > > is required for the chip to run successfully. > > > > > > Cc: Steve Glendinning > > > Cc: netdev@vger.kernel.org > > > Signed-off-by: Lee Jones > >=20 > > Seems to me like it'll do the trick. > > Acked-by: Linus Walleij >=20 > This looks fairly dangerous. What about those platforms which use th= is > driver, but don't provide a clock for it? >=20 > It looks like this will result in those platforms losing their ethern= et > support. There's at least a bunch of the ARM evaluation boards which > make use of this driver... Right, but nothing should regress. If no clock is provided the driver moves on during the request and will refuse to prepare, enable and disable there after.=20 Unless I've made a mistake somewhere? If so, I'd be happy to fixup. --=20 Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog