From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: sock_ioctl sleeping while atomic warning during boot.
Date: Fri, 21 Dec 2012 13:15:04 -0800 (PST)
Message-ID: <20121221.131504.402952074906485532.davem@davemloft.net>
References: <20121221022409.GA1927@redhat.com>
	<1356060308.21834.4455.camel@edumazet-glaptop>
	<50D3D7F7.2030200@hp.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: eric.dumazet@gmail.com, davej@redhat.com, netdev@vger.kernel.org
To: brian.haley@hp.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([149.20.54.216]:44549 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750876Ab2LUVPI (ORCPT
	<rfc822;netdev@vger.kernel.org>); Fri, 21 Dec 2012 16:15:08 -0500
In-Reply-To: <50D3D7F7.2030200@hp.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Brian Haley <brian.haley@hp.com>
Date: Thu, 20 Dec 2012 22:31:03 -0500

> On 12/20/2012 10:25 PM, Eric Dumazet wrote:
>> OK, thanks for the report.
>> 
>> We need a seqcount, not a seqlock, as RTNL already protects multiple
>> writers.
>> 
>> Please try following fix :
>> 
>> 
>> [PATCH] net: devnet_rename_seq should be a seqcount
>> 
>> Using a seqlock for devnet_rename_seq is not a good idea,
>> as device_rename() can sleep.
>> 
>> As we hold RTNL, we dont need a protection for writers,
>> and only need a seqcount so that readers can catch a change done
>> by a writer.
>> 
>> Bug added in commit c91f6df2db4972d3 (sockopt: Change getsockopt() of
>> SO_BINDTODEVICE to return an interface name)
>> 
>> Reported-by: Dave Jones <davej@redhat.com>
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>> Cc: Brian Haley <brian.haley@hp.com>
> 
> Sorry about that, thanks for the quick fix Eric.

Applied.