From: David Miller <davem@davemloft.net>
To: erdnetdev@gmail.com
Cc: netdev@vger.kernel.org, yanb@mellanox.com, shemminger@vyatta.com
Subject: Re: [PATCH] ipv4: arp: fix a lockdep splat in arp_solicit()
Date: Fri, 21 Dec 2012 13:16:04 -0800 (PST) [thread overview]
Message-ID: <20121221.131604.630440467916062914.davem@davemloft.net> (raw)
In-Reply-To: <1356111130.21834.7565.camel@edumazet-glaptop>
From: Eric Dumazet <erdnetdev@gmail.com>
Date: Fri, 21 Dec 2012 09:32:10 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Yan Burman reported following lockdep warning :
...
> Bug is from arp_solicit(), releasing the neigh lock after arp_send()
> In case of vxlan, we eventually need to write lock a neigh lock later.
>
> Its a false positive, but we can get rid of it without lockdep
> annotations.
>
> We can instead use neigh_ha_snapshot() helper.
>
> Reported-by: Yan Burman <yanb@mellanox.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
prev parent reply other threads:[~2012-12-21 21:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 17:32 [PATCH] ipv4: arp: fix a lockdep splat in arp_solicit() Eric Dumazet
2012-12-21 21:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121221.131604.630440467916062914.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erdnetdev@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=yanb@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).