From: David Miller <davem@davemloft.net>
To: david.woodhouse@intel.com
Cc: dan.carpenter@oracle.com, chas@cmf.nrl.navy.mil,
nathan@traverse.com.au, linux-atm-general@lists.sourceforge.net,
netdev@vger.kernel.org, kbuild@01.org
Subject: Re: [patch] solos-pci: double lock in geos_gpio_store()
Date: Fri, 21 Dec 2012 13:16:46 -0800 (PST) [thread overview]
Message-ID: <20121221.131646.463198363776718641.davem@davemloft.net> (raw)
In-Reply-To: <1355995348.18919.104.camel@shinybook.infradead.org>
From: "Woodhouse, David" <david.woodhouse@intel.com>
Date: Thu, 20 Dec 2012 09:22:26 +0000
> On Thu, 2012-12-20 at 10:48 +0300, Dan Carpenter wrote:
>> There is a typo here so we do a double lock instead of an unlock.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> ---
>> Only needed in linux-next. Introduced in f9baad02e7411d9 [14/17]
>> solos-pci: add GPIO support for newer versions on Geos board
>
> Ah, crap. That was my fault; it was part of my "improvement" to Nathan's
> patch. Sorry.
>
> Acked-by: David Woodhouse <David.Woodhouse@intel.com>
Applied.
prev parent reply other threads:[~2012-12-21 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50d25b88.0QAOhrb1a/eK/hR1%fengguang.wu@intel.com>
2012-12-20 7:48 ` [patch] solos-pci: double lock in geos_gpio_store() Dan Carpenter
2012-12-20 9:22 ` Woodhouse, David
2012-12-21 21:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121221.131646.463198363776718641.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chas@cmf.nrl.navy.mil \
--cc=dan.carpenter@oracle.com \
--cc=david.woodhouse@intel.com \
--cc=kbuild@01.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=nathan@traverse.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).