* [patch] solos-pci: double lock in geos_gpio_store() [not found] <50d25b88.0QAOhrb1a/eK/hR1%fengguang.wu@intel.com> @ 2012-12-20 7:48 ` Dan Carpenter 2012-12-20 9:22 ` Woodhouse, David 0 siblings, 1 reply; 3+ messages in thread From: Dan Carpenter @ 2012-12-20 7:48 UTC (permalink / raw) To: Chas Williams, Nathan Williams, David Woodhouse Cc: linux-atm-general, netdev, kbuild There is a typo here so we do a double lock instead of an unlock. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Only needed in linux-next. Introduced in f9baad02e7411d9 [14/17] solos-pci: add GPIO support for newer versions on Geos board diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c index 473d808..7b95736 100644 --- a/drivers/atm/solos-pci.c +++ b/drivers/atm/solos-pci.c @@ -531,7 +531,7 @@ static ssize_t geos_gpio_store(struct device *dev, struct device_attribute *attr } else { count = -EINVAL; } - spin_lock_irq(&card->param_queue_lock); + spin_unlock_irq(&card->param_queue_lock); return count; } ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] solos-pci: double lock in geos_gpio_store() 2012-12-20 7:48 ` [patch] solos-pci: double lock in geos_gpio_store() Dan Carpenter @ 2012-12-20 9:22 ` Woodhouse, David 2012-12-21 21:16 ` David Miller 0 siblings, 1 reply; 3+ messages in thread From: Woodhouse, David @ 2012-12-20 9:22 UTC (permalink / raw) To: Dan Carpenter Cc: Chas Williams, Nathan Williams, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, kbuild@01.org On Thu, 2012-12-20 at 10:48 +0300, Dan Carpenter wrote: > There is a typo here so we do a double lock instead of an unlock. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > Only needed in linux-next. Introduced in f9baad02e7411d9 [14/17] > solos-pci: add GPIO support for newer versions on Geos board Ah, crap. That was my fault; it was part of my "improvement" to Nathan's patch. Sorry. Acked-by: David Woodhouse <David.Woodhouse@intel.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] solos-pci: double lock in geos_gpio_store() 2012-12-20 9:22 ` Woodhouse, David @ 2012-12-21 21:16 ` David Miller 0 siblings, 0 replies; 3+ messages in thread From: David Miller @ 2012-12-21 21:16 UTC (permalink / raw) To: david.woodhouse Cc: dan.carpenter, chas, nathan, linux-atm-general, netdev, kbuild From: "Woodhouse, David" <david.woodhouse@intel.com> Date: Thu, 20 Dec 2012 09:22:26 +0000 > On Thu, 2012-12-20 at 10:48 +0300, Dan Carpenter wrote: >> There is a typo here so we do a double lock instead of an unlock. >> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >> --- >> Only needed in linux-next. Introduced in f9baad02e7411d9 [14/17] >> solos-pci: add GPIO support for newer versions on Geos board > > Ah, crap. That was my fault; it was part of my "improvement" to Nathan's > patch. Sorry. > > Acked-by: David Woodhouse <David.Woodhouse@intel.com> Applied. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-21 21:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <50d25b88.0QAOhrb1a/eK/hR1%fengguang.wu@intel.com>
2012-12-20 7:48 ` [patch] solos-pci: double lock in geos_gpio_store() Dan Carpenter
2012-12-20 9:22 ` Woodhouse, David
2012-12-21 21:16 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).