From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 4/4] net/smsc911x: Provide common clock functionality Date: Fri, 21 Dec 2012 09:24:21 +0000 Message-ID: <20121221092421.GG14363@n2100.arm.linux.org.uk> References: <1355937587-31730-1-git-send-email-lee.jones@linaro.org> <1355937587-31730-4-git-send-email-lee.jones@linaro.org> <20121220192441.GC14363@n2100.arm.linux.org.uk> <20121220203514.GN2691@gmail.com> <20121220205113.GD14363@n2100.arm.linux.org.uk> <20121221091306.GO2691@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Walleij , Steve Glendinning , Robert Marklund , linus.walleij@stericsson.com, arnd@arndb.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Lee Jones Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:35356 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546Ab2LUJZk (ORCPT ); Fri, 21 Dec 2012 04:25:40 -0500 Content-Disposition: inline In-Reply-To: <20121221091306.GO2691@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Dec 21, 2012 at 09:13:06AM +0000, Lee Jones wrote: > Are you saying remove "pdata->clk = NULL;" and test for IS_ERR > every time? Exactly.