From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH 2/2] cpts: fix a run time warn_on.
Date: Mon, 24 Dec 2012 07:46:59 +0100
Message-ID: <20121224064658.GA2390@netboy.at.omicron.at>
References: <cover.1356204860.git.richardcochran@gmail.com>
 <ad26ca328f0eba6a722d0288ac1c37ad55789447.1356204860.git.richardcochran@gmail.com>
 <50D7101A.6020506@mvista.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, Mugunthan V N <mugunthanvnm@ti.com>,
	linux-omap@vger.kernel.org, David Miller <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org,
	Cyril Chemparathy <cyril@ti.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Return-path: <linux-omap-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <50D7101A.6020506@mvista.com>
Sender: linux-omap-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Sun, Dec 23, 2012 at 06:07:22PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 22-12-2012 23:41, Richard Cochran wrote:
> 
> >This patch fixes a warning in clk_enable by calling clk_prepare first.
> 
> >Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> >---
> >  drivers/net/ethernet/ti/cpts.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> >diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
> >index 5ab8fb4..3e32a31 100644
> >--- a/drivers/net/ethernet/ti/cpts.c
> >+++ b/drivers/net/ethernet/ti/cpts.c
> >@@ -247,6 +247,7 @@ static void cpts_clk_init(struct cpts *cpts)
> >  		cpts->refclk = NULL;
> >  		return;
> >  	}
> >+	clk_prepare(cpts->refclk);
> >  	clk_enable(cpts->refclk);
> 
>    Maybe just call clk_prepare_enable() instead?

Okay, will fix in v2.

Thanks,
Richard