From: David Miller <davem@davemloft.net>
To: yamahata@valinux.co.jp
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] ipv6/ip6_gre: set transport header correctly
Date: Wed, 26 Dec 2012 15:20:31 -0800 (PST) [thread overview]
Message-ID: <20121226.152031.261734320140670444.davem@davemloft.net> (raw)
In-Reply-To: <8b3ad21951fd0ab05910ce5d4f4646142b18663a.1356403806.git.yamahata@valinux.co.jp>
From: Isaku Yamahata <yamahata@valinux.co.jp>
Date: Tue, 25 Dec 2012 11:51:04 +0900
> ip6gre_xmit2() incorrectly sets transport header to inner payload
> instead of GRE header. It seems copy-and-pasted from ipip.c.
> Set transport header to gre header.
> (In ipip case the transport header is the inner ip header, so that's
> correct.)
>
> Found by inspection. In practice the incorrect transport header
> doesn't matter because the skb usually is sent to another net_device
> or socket, so the transport header isn't referenced.
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Applied.
next prev parent reply other threads:[~2012-12-26 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-25 2:51 [PATCH 1/2] ipv4/ip_gre: set transport header correctly to gre header Isaku Yamahata
2012-12-25 2:51 ` [PATCH 2/2] ipv6/ip6_gre: set transport header correctly Isaku Yamahata
2012-12-26 23:20 ` David Miller [this message]
2012-12-26 23:20 ` [PATCH 1/2] ipv4/ip_gre: set transport header correctly to gre header David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121226.152031.261734320140670444.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).