public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Timo Teras <timo.teras@iki.fi>
To: netdev@vger.kernel.org
Subject: netlink NLM_F_DUMP for unsupported address family / PF_UNSPEC
Date: Thu, 27 Dec 2012 17:19:17 +0200	[thread overview]
Message-ID: <20121227171917.07419887@vostro> (raw)

It seems that currently PF_UNSPEC is overloaded when dumping rtnetlink
things. It is used for two purposes: as wildcard entry to dump
all protocol families, and as fallback for unsupported families.

On my system with IPv[46] only and no IPX, running "ip -f ipx
route" would print the IPv4 and IPv6 routes instead of "unsupported" or
"not implemented" error which is rather confusing and unexpected.

Just removing the fallback from rtnl_get_dumpit() does not sound right
since some commands seem to rely on this behaviour e.g. RTM_GETQDISC.

Perhaps rtnl_dump_all should check that request family truly was
PF_UNSPEC or error out if not?

- Timo

                 reply	other threads:[~2012-12-27 15:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121227171917.07419887@vostro \
    --to=timo.teras@iki.fi \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox