* [PATCH] skbuff: make __kmalloc_reserve static
@ 2012-12-29 4:24 Stephen Hemminger
2012-12-29 4:33 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2012-12-29 4:24 UTC (permalink / raw)
To: David Miller, Eric Dumazet; +Cc: netdev
Sparse detected case where this local function should be static.
It may even allow some compiler optimizations.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/core/skbuff.c 2012-12-28 19:46:31.967615872 -0800
+++ b/net/core/skbuff.c 2012-12-28 20:00:33.343165940 -0800
@@ -155,8 +155,9 @@ static void skb_under_panic(struct sk_bu
*/
#define kmalloc_reserve(size, gfp, node, pfmemalloc) \
__kmalloc_reserve(size, gfp, node, _RET_IP_, pfmemalloc)
-void *__kmalloc_reserve(size_t size, gfp_t flags, int node, unsigned long ip,
- bool *pfmemalloc)
+
+static void *__kmalloc_reserve(size_t size, gfp_t flags, int node,
+ unsigned long ip, bool *pfmemalloc)
{
void *obj;
bool ret_pfmemalloc = false;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] skbuff: make __kmalloc_reserve static
2012-12-29 4:24 [PATCH] skbuff: make __kmalloc_reserve static Stephen Hemminger
@ 2012-12-29 4:33 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-12-29 4:33 UTC (permalink / raw)
To: shemminger; +Cc: edumazet, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 28 Dec 2012 20:24:28 -0800
> Sparse detected case where this local function should be static.
> It may even allow some compiler optimizations.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-29 4:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-29 4:24 [PATCH] skbuff: make __kmalloc_reserve static Stephen Hemminger
2012-12-29 4:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).