From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: fbl@redhat.com, netdev@vger.kernel.org, jiri@resnulli.us
Subject: Re: [PATCH net-next] team: add ethtool support
Date: Sat, 29 Dec 2012 17:35:30 -0800 (PST) [thread overview]
Message-ID: <20121229.173530.463452112273354773.davem@davemloft.net> (raw)
In-Reply-To: <20121229172945.25a09fc8@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Sat, 29 Dec 2012 17:29:45 -0800
> On Sat, 29 Dec 2012 23:19:26 -0200
> Flavio Leitner <fbl@redhat.com> wrote:
>
>> This patch adds few ethtool operations to team driver.
>>
>> Signed-off-by: Flavio Leitner <fbl@redhat.com>
>
> What is the motivation for this? Is there an application that depends
> on ethtool (versus netlink, or /proc)?
>
> Sorry, I see no point in providing ethtool statistics for generic data that is already
> reported by existing netlink and other infrastructure. The purpose of ethtool
> statistics is to report device specific that is not available through the normal
> generic statistics.
Agreed, ethtool stats should _ONLY_ report device specific
statistics.
next prev parent reply other threads:[~2012-12-30 1:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-30 1:19 [PATCH net-next] team: add ethtool support Flavio Leitner
2012-12-30 1:29 ` Stephen Hemminger
2012-12-30 1:35 ` David Miller [this message]
2012-12-30 1:44 ` Flavio Leitner
2012-12-30 2:09 ` David Miller
2012-12-30 2:30 ` Flavio Leitner
2012-12-30 2:31 ` Eric Dumazet
2013-01-10 16:27 ` Ben Hutchings
2013-01-10 17:51 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121229.173530.463452112273354773.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fbl@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).