From: David Miller <davem@davemloft.net>
To: dborkman@redhat.com
Cc: ani@aristanetworks.com, netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] net: filter: return -EINVAL if BPF_S_ANC* operation is not supported
Date: Sun, 30 Dec 2012 02:30:58 -0800 (PST) [thread overview]
Message-ID: <20121230.023058.1273764783843598991.davem@davemloft.net> (raw)
In-Reply-To: <1356727817-10649-1-git-send-email-dborkman@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Fri, 28 Dec 2012 21:50:17 +0100
> Currently, we return -EINVAL for malformed or wrong BPF filters.
> However, this is not done for BPF_S_ANC* operations, which makes it
> more difficult to detect if it's actually supported or not by the
> BPF machine. Therefore, we should also return -EINVAL if K is within
> the SKF_AD_OFF universe and the ancillary operation did not match.
...
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> Reported-by: Ani Sinha <ani@aristanetworks.com>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2012-12-30 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 20:50 [PATCH net-next] net: filter: return -EINVAL if BPF_S_ANC* operation is not supported Daniel Borkmann
2012-12-30 10:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121230.023058.1273764783843598991.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ani@aristanetworks.com \
--cc=dborkman@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).