From: David Miller <davem@davemloft.net>
To: ariele@broadcom.com
Cc: netdev@vger.kernel.org, eilong@broadcom.com
Subject: Re: [PATCH net-next v4 04/22] bnx2x: Separate VF and PF logic
Date: Sun, 30 Dec 2012 17:35:13 -0800 (PST) [thread overview]
Message-ID: <20121230.173513.545111396374915524.davem@davemloft.net> (raw)
In-Reply-To: <1356897442-3063-5-git-send-email-ariele@broadcom.com>
From: "Ariel Elior" <ariele@broadcom.com>
Date: Sun, 30 Dec 2012 21:57:04 +0200
> Generally, the VF driver cannot access the chip, except by the
> narrow window its BAR allows. Care had to be taken so the VF driver
> will not reach code which accesses the chip elsewhere.
> Refactor the nic_load flow into parts so it would be
> easier to separate the VF-only logic from the PF-only logic.
>
> Signed-off-by: Ariel Elior <ariele@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
This introduces warnings:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c: In function ‘bnx2x_open’:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:11311:7: warning: ‘load_status’ may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:11312:18: warning: ‘other_load_status’ may be used uninitialized in this function [-Wmaybe-uninitialized]
This is with gcc-4.7.2 on Fedora 17
next prev parent reply other threads:[~2012-12-31 1:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-30 19:57 [PATCH v3 net-next 00/22] bnx2x: support SR-IOV Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 01/22] bnx2x: Support probing and removing of VF device Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 02/22] bnx2x: VF <-> PF channel 'acquire' at vf probe Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 03/22] bnx2x: Add to VF <-> PF channel the release request Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 04/22] bnx2x: Separate VF and PF logic Ariel Elior
2012-12-31 1:35 ` David Miller [this message]
2012-12-30 19:57 ` [PATCH net-next v4 05/22] bnx2x: Add init, setup_q, set_mac to VF <-> PF channel Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 06/22] bnx2x: Add teardown_q and close " Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 07/22] bnx2x: Support ndo_set_rxmode in VF driver Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 08/22] bnx2x: VF fastpath Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 09/22] bnx2x: Allocate VF database in PF when VFs are present Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 10/22] bnx2x: Prepare device and initialize VF database Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 11/22] bnx2x: Infrastructure for VF <-> PF request on PF side Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 12/22] bnx2x: Support of PF driver of a VF acquire request Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 13/22] bnx2x: Support of PF driver of a VF init request Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 14/22] bnx2x: Support statistics collection for VFs by the PF Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 15/22] bnx2x: Support of PF driver of a VF setup_q request Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 16/22] bnx2x: Support of PF driver of a VF q_filters request Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 17/22] bnx2x: Support of PF driver of a VF q_teardown request Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 18/22] bnx2x: Support of PF driver of a VF close request Ariel Elior
2012-12-31 1:42 ` David Miller
2012-12-30 19:57 ` [PATCH net-next v4 19/22] bnx2x: Support of PF driver of a VF release request Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 20/22] bnx2x: Support VF FLR Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 21/22] bnx2x: Support PF <-> VF Bulletin Board Ariel Elior
2012-12-30 19:57 ` [PATCH net-next v4 22/22] bnx2x: Add VF device ids and enable feature Ariel Elior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121230.173513.545111396374915524.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariele@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).