* [PATCH net-next] team: implement carrier change
@ 2012-12-30 1:31 Flavio Leitner
2012-12-30 8:50 ` Jiri Pirko
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Flavio Leitner @ 2012-12-30 1:31 UTC (permalink / raw)
To: netdev; +Cc: Jiri Pirko, Flavio Leitner
The user space teamd daemon may need to control the
master's carrier state depending on the selected mode.
Signed-off-by: Flavio Leitner <fbl@redhat.com>
---
drivers/net/team/team.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index f711039..14cb843 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -1708,6 +1708,15 @@ static netdev_features_t team_fix_features(struct net_device *dev,
return features;
}
+static int team_change_carrier(struct net_device *dev, bool new_carrier)
+{
+ if (new_carrier)
+ netif_carrier_on(dev);
+ else
+ netif_carrier_off(dev);
+ return 0;
+}
+
static const struct net_device_ops team_netdev_ops = {
.ndo_init = team_init,
.ndo_uninit = team_uninit,
@@ -1730,6 +1739,7 @@ static const struct net_device_ops team_netdev_ops = {
.ndo_add_slave = team_add_slave,
.ndo_del_slave = team_del_slave,
.ndo_fix_features = team_fix_features,
+ .ndo_change_carrier = team_change_carrier,
};
/***********************
--
1.8.0.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next] team: implement carrier change
2012-12-30 1:31 [PATCH net-next] team: implement carrier change Flavio Leitner
@ 2012-12-30 8:50 ` Jiri Pirko
2012-12-30 10:32 ` David Miller
2012-12-30 13:03 ` Michał Mirosław
2 siblings, 0 replies; 5+ messages in thread
From: Jiri Pirko @ 2012-12-30 8:50 UTC (permalink / raw)
To: Flavio Leitner; +Cc: netdev
Sun, Dec 30, 2012 at 02:31:01AM CET, fbl@redhat.com wrote:
>The user space teamd daemon may need to control the
>master's carrier state depending on the selected mode.
>
>Signed-off-by: Flavio Leitner <fbl@redhat.com>
>---
> drivers/net/team/team.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
>index f711039..14cb843 100644
>--- a/drivers/net/team/team.c
>+++ b/drivers/net/team/team.c
>@@ -1708,6 +1708,15 @@ static netdev_features_t team_fix_features(struct net_device *dev,
> return features;
> }
>
>+static int team_change_carrier(struct net_device *dev, bool new_carrier)
>+{
>+ if (new_carrier)
>+ netif_carrier_on(dev);
>+ else
>+ netif_carrier_off(dev);
>+ return 0;
>+}
>+
> static const struct net_device_ops team_netdev_ops = {
> .ndo_init = team_init,
> .ndo_uninit = team_uninit,
>@@ -1730,6 +1739,7 @@ static const struct net_device_ops team_netdev_ops = {
> .ndo_add_slave = team_add_slave,
> .ndo_del_slave = team_del_slave,
> .ndo_fix_features = team_fix_features,
>+ .ndo_change_carrier = team_change_carrier,
> };
>
> /***********************
>--
>1.8.0.1
Acked-by: Jiri Pirko <jiri@resnulli.us>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] team: implement carrier change
2012-12-30 1:31 [PATCH net-next] team: implement carrier change Flavio Leitner
2012-12-30 8:50 ` Jiri Pirko
@ 2012-12-30 10:32 ` David Miller
2012-12-30 13:03 ` Michał Mirosław
2 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2012-12-30 10:32 UTC (permalink / raw)
To: fbl; +Cc: netdev, jiri
From: Flavio Leitner <fbl@redhat.com>
Date: Sat, 29 Dec 2012 23:31:01 -0200
> The user space teamd daemon may need to control the
> master's carrier state depending on the selected mode.
>
> Signed-off-by: Flavio Leitner <fbl@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] team: implement carrier change
2012-12-30 1:31 [PATCH net-next] team: implement carrier change Flavio Leitner
2012-12-30 8:50 ` Jiri Pirko
2012-12-30 10:32 ` David Miller
@ 2012-12-30 13:03 ` Michał Mirosław
2012-12-30 13:06 ` Jiri Pirko
2 siblings, 1 reply; 5+ messages in thread
From: Michał Mirosław @ 2012-12-30 13:03 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, Flavio Leitner
2012/12/30 Flavio Leitner <fbl@redhat.com>:
> The user space teamd daemon may need to control the
> master's carrier state depending on the selected mode.
[...]
> +static int team_change_carrier(struct net_device *dev, bool new_carrier)
> +{
> + if (new_carrier)
> + netif_carrier_on(dev);
> + else
> + netif_carrier_off(dev);
> + return 0;
> +}
> +
[...]
> + .ndo_change_carrier = team_change_carrier,
I wonder what else you might put in the .ndo_change_carrier
implementation? It's already the same for dummy device and tunnels
would get more copies. Maybe it would be enough to allocate a bit in
netdev->priv_flags and use that in dev_change_carrier() instead?
Best Regards,
Michał Mirosław
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] team: implement carrier change
2012-12-30 13:03 ` Michał Mirosław
@ 2012-12-30 13:06 ` Jiri Pirko
0 siblings, 0 replies; 5+ messages in thread
From: Jiri Pirko @ 2012-12-30 13:06 UTC (permalink / raw)
To: Michał Mirosław; +Cc: netdev, Flavio Leitner
30. 12. 2012 v 14:03, Michał Mirosław <mirqus@gmail.com>:
> 2012/12/30 Flavio Leitner <fbl@redhat.com>:
>> The user space teamd daemon may need to control the
>> master's carrier state depending on the selected mode.
> [...]
>> +static int team_change_carrier(struct net_device *dev, bool new_carrier)
>> +{
>> + if (new_carrier)
>> + netif_carrier_on(dev);
>> + else
>> + netif_carrier_off(dev);
>> + return 0;
>> +}
>> +
> [...]
>> + .ndo_change_carrier = team_change_carrier,
>
> I wonder what else you might put in the .ndo_change_carrier
> implementation? It's already the same for dummy device and tunnels
> would get more copies. Maybe it would be enough to allocate a bit in
> netdev->priv_flags and use that in dev_change_carrier() instead?
>
Flavio has a patch adding some more code here prepared already. Will be posted soon.
> Best Regards,
> Michał Mirosław
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-12-30 13:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-30 1:31 [PATCH net-next] team: implement carrier change Flavio Leitner
2012-12-30 8:50 ` Jiri Pirko
2012-12-30 10:32 ` David Miller
2012-12-30 13:03 ` Michał Mirosław
2012-12-30 13:06 ` Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).