From: Flavio Leitner <fbl@redhat.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] team: update master carrier state
Date: Sun, 30 Dec 2012 20:06:16 -0200 [thread overview]
Message-ID: <20121230220616.GA2065@obelix.rh> (raw)
In-Reply-To: <20121230214723.GD1575@minipsycho.orion>
On Sun, Dec 30, 2012 at 10:47:23PM +0100, Jiri Pirko wrote:
> Sun, Dec 30, 2012 at 07:27:29PM CET, fbl@redhat.com wrote:
> >Update master's carrier state when there is any
> >change with its ports.
>
>
> This patch looks good to me. Just one nitpick I spotted....
>
> >+ bool team_linkup;
> >+
> >+ team_linkup = false;
>
>
> This can be squashed together.
Ok, but that increases the static size of the module because it
moves the variable out of bss.
I have no strong opinion on either case, so it's up to you.
Thanks,
--
fbl
next prev parent reply other threads:[~2012-12-30 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-30 18:27 [PATCH net-next] team: update master carrier state Flavio Leitner
2012-12-30 21:47 ` Jiri Pirko
2012-12-30 22:06 ` Flavio Leitner [this message]
2012-12-30 22:10 ` Jiri Pirko
2013-01-03 10:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121230220616.GA2065@obelix.rh \
--to=fbl@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).