netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: amwang@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/3] netpoll: add IPv6 support
Date: Thu, 03 Jan 2013 19:20:41 -0800 (PST)	[thread overview]
Message-ID: <20130103.192041.782458185484678551.davem@davemloft.net> (raw)
In-Reply-To: <1357269273-7575-1-git-send-email-amwang@redhat.com>

From: Cong Wang <amwang@redhat.com>
Date: Fri,  4 Jan 2013 11:14:30 +0800

> (Resend with a cover letter)
> 
> v3: fix CONFIG_IPV6=m case
> 
> v2: use bool for ipv6 flag
>     fix !CONFIG_IPV6 case
> 
> This patchset implements netpoll over IPv6.

Thanks for submitting this properly.

But disallowing ipv6 netpoll support when IPV6=m is an unacceptable
limitation, compiling IPV6 as a module is common and in fact
recommended.

We've solved problems like this before, by putting the needed ipv6
routines into a seperate library that is built statically into the
kernel when necessary.

You should use a similar approach here.

Thanks.

  parent reply	other threads:[~2013-01-04  3:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04  3:14 [PATCH net-next v3 0/3] netpoll: add IPv6 support Cong Wang
2013-01-04  3:14 ` [PATCH net-next v3 1/3] netpoll: prepare for ipv6 Cong Wang
2013-01-04  3:14 ` [PATCH net-next v3 2/3] netpoll: add IPv6 support Cong Wang
2013-01-04  3:14 ` [PATCH net-next v3 3/3] netconsole: add IPv6 example in doc Cong Wang
2013-01-04  3:20 ` David Miller [this message]
2013-01-07  2:58   ` [PATCH net-next v3 0/3] netpoll: add IPv6 support Cong Wang
2013-01-07  3:49     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130103.192041.782458185484678551.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=amwang@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).